Repository navigation
Resolve seven npm Dependabot alerts in UI and GitHub scripts - #5109
Conversation
Co-authored-by: JayDoubleu <40270505+JayDoubleu@users.noreply.github.com>
Co-authored-by: JayDoubleu <40270505+JayDoubleu@users.noreply.github.com>
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 7e77b2d) (in response to this comment from Jay W (@JayDoubleu)) |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All targeted dependencies, package metadata, and changelog details match the stated acceptance criteria.
Review effort: Balanced
Findings: None
What changed in this PR
Resolves seven npm security alerts across the UI and GitHub workflow scripts.
Changes:
- Updates vulnerable
fast-uri,moment, andbrace-expansionversions. - Bumps UI and build-script patch versions.
- Documents the fixes in the Unreleased changelog.
| File | Description |
|---|---|
ui/app/package.json |
Bumps UI and Moment versions. |
ui/app/package-lock.json |
Locks patched dependency versions. |
.github/scripts/package.json |
Bumps build-scripts version. |
.github/scripts/package-lock.json |
Updates brace-expansion while preserving 5.x. |
CHANGELOG.md |
Records the security fixes and versions. |
Files not reviewed (2)
- .github/scripts/package-lock.json: Generated file
- ui/app/package-lock.json: Generated file
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All targeted dependency versions, package metadata, and changelog requirements are correctly synchronized.
Review effort: Balanced
Findings: None
Files not reviewed (2)
- .github/scripts/package-lock.json: Generated file
- ui/app/package-lock.json: Generated file
Unit Test Results309 tests 309 ✅ 52s ⏱️ Results for commit 785dd43. |
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 785dd43) (in response to this comment from Jay W (@JayDoubleu)) |
Resolves #5108
What is being addressed
Seven npm Dependabot alerts affecting the UI and GitHub workflow script lockfiles, including vulnerable
fast-uri,moment, andbrace-expansionversions.How is this addressed
fast-uri3.1.6 → 3.1.8,moment2.30.1 → 2.31.0, all fourbrace-expansion1.x copies 1.1.18 → 1.1.21, and the UI 2.x copy 2.1.4 → 2.1.7.brace-expansion2.1.4 → 2.1.7 while preserving its compatible 5.0.12 copy.ui0.9.0 → 0.9.1 andbuild-scripts1.0.0 → 1.0.1; synchronize lockfile metadata/integrity and add the Unreleased changelog entry.npm cipassed in both packages; neither clean install rewrote its manifest or lockfile.src/config.jsonfrom the CI source config; coverage passed (32 files, 309 tests).npm audit --jsonreports 0 vulnerabilities. UI audit reports 6 high vulnerabilities unrelated to this change; the unchanged baseline had those same findings plus the fixedfast-uri,brace-expansion, andmomentadvisories (8 high, 1 moderate total).git diff --checkpassed.Local npm audits confirm the targeted versions are outside the listed vulnerable ranges; GitHub's post-merge security scan is still needed to confirm alert closure.