Repository navigation
Pin GitHub-hosted runners to Ubuntu 26.04 and fix certificate workflow setup - #5285
Max Martin (maxmartin-cgi) wants to merge 3 commits into
Conversation
Port bjss/AzureTRE-CGI#84 at b5a51d2f0968577c7483ef2d1c1e44f3b7bcd72c onto current upstream main. Co-authored-by: Jay W <40270505+JayDoubleu@users.noreply.github.com>
|
Local pre-commit hooks, actionlint syntax/expression checks and all 290 GitHub-script tests under Node.js 24.22.2 passed for the current revision, The historical CI and live Azure results below assessed
Retries and limits:
Both PR and branch test environments were removed. Temporary validation branches/worktrees were removed; PR code and its branch were preserved. |
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit abe51df. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
🔵 Needs a closer look
Maintainer review is needed because live Azure validation predates the current head and certificate renewal remains untested on Ubuntu 26.04 with the preinstalled Azure CLI.
No open issues 🎉
What changed in this PR
Addresses #5273 by pinning Azure TRE’s GitHub Actions runners, preventing image changes caused by the moving ubuntu-latest label, and fixing certificate-renewal setup.
Changes:
- Pin jobs using
ubuntu-latestand the CodeQL job toubuntu-26.04, retaining the threeubuntu-slimjobs. - Allow the new runner label in actionlint.
- Use the preinstalled Azure CLI for certificate renewal, refresh the apt index before installing dependencies, and document the fixes.
| File | Description |
|---|---|
CHANGELOG.md |
Record the runner and certificate-workflow fixes. |
.github/workflows/test_results.yml |
Pin the test-results runner. |
.github/workflows/resource_processor_tests.yml |
Pin the resource-processor test runner. |
.github/workflows/pr_comment_bot.yml |
Pin environment preparation and destruction runners. |
.github/workflows/lets_encrypt.yml |
Pin the runner, remove the Azure CLI install, and refresh apt. |
.github/workflows/e2e_helper_tests.yml |
Pin the E2E helper test runner. |
.github/workflows/deploy_tre_reusable.yml |
Pin deployment, bundle, and E2E runners. |
.github/workflows/deploy_tre_branch.yml |
Pin the branch-preparation runner. |
.github/workflows/codeql-analysis.yml |
Move CodeQL from Ubuntu 22.04 to 26.04. |
.github/workflows/cli-package.yml |
Pin the CLI packaging runner. |
.github/workflows/clean_validation_envs.yml |
Pin cleanup and validation runners. |
.github/workflows/build_validation_develop.yml |
Pin the lint runner. |
.github/workflows/build_docker_images.yml |
Pin the image-build runner. |
.github/workflows/build_all_dockerfiles.yml |
Pin discovery, build, and summary runners. |
.github/linters/actionlint.yml |
Allow the ubuntu-26.04 runner label. |
Review effort: Balanced
The ubuntu-latest label moves to Ubuntu 26 from 19 October 2026. The actionlint lines are the same as in microsoft/AzureTRE#5285, so a later sync of main applies them without a conflict.
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/41667782266 (in response to this comment from Chris Chapman (@ChrisChapman-gh)) |
Resolves #5273
What is being addressed
The
ubuntu-latesttransition can select either Ubuntu 24.04 or 26.04, and future label changes can alter CI without a repository change. CodeQL still selects Ubuntu 22.04. Certificate renewal also pins an Azure CLI apt package unavailable on current runner images.How is this addressed
ubuntu-latest, plus CodeQL, toubuntu-26.04; retain the threeubuntu-slimjobs.ubuntu-26.04in the pinned actionlint version's runner-label configuration.This replaces the narrower approach in closed #5275.
Validation
Local checks at
3c077cca37deb6f20fb0f457d7d3f5274899abd7:CHANGELOG.md.Earlier CI and live Azure results are included in a separate comment. They assessed commit
4e2d49cda2c6005c41ef722b70cd9272171a8620; the live tests have not been repeated after applying these changes to the currentmainbase. Let's Encrypt renewal was excluded from that validation.