Skip to content

Pin GitHub-hosted runners to Ubuntu 26.04 and fix certificate workflow setup - #5285

Open
Max Martin (maxmartin-cgi) wants to merge 3 commits into
microsoft:mainfrom
maxmartin-cgi:fix/pin-ubuntu-2604-runners
Open

Max Martin (maxmartin-cgi) wants to merge 3 commits into
microsoft:mainfrom
maxmartin-cgi:fix/pin-ubuntu-2604-runners

Conversation

@maxmartin-cgi

@maxmartin-cgi Max Martin (maxmartin-cgi) commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Resolves #5273

What is being addressed

The ubuntu-latest transition can select either Ubuntu 24.04 or 26.04, and future label changes can alter CI without a repository change. CodeQL still selects Ubuntu 22.04. Certificate renewal also pins an Azure CLI apt package unavailable on current runner images.

How is this addressed

  • Pin all jobs using ubuntu-latest, plus CodeQL, to ubuntu-26.04; retain the three ubuntu-slim jobs.
  • Allow ubuntu-26.04 in the pinned actionlint version's runner-label configuration.
  • Use the preinstalled Azure CLI for Let's Encrypt and refresh the apt package index before installing renewal dependencies.
  • Add an Unreleased bug-fix entry linked to Workflows depend on the ubuntu-latest label, which moves to Ubuntu 26.04 #5273.

This replaces the narrower approach in closed #5275.

Validation

Local checks at 3c077cca37deb6f20fb0f457d7d3f5274899abd7:

  • Applicable pre-commit hooks passed for all 15 changed files, including Markdown lint on CHANGELOG.md.
  • Actionlint 1.7.12 syntax/expression checks passed (external ShellCheck/Pyflakes disabled).
  • All 290 GitHub-script tests passed using Node.js 24.22.2, matching CI's Node.js 24 selection.

Earlier CI and live Azure results are included in a separate comment. They assessed commit 4e2d49cda2c6005c41ef722b70cd9272171a8620; the live tests have not been repeated after applying these changes to the current main base. Let's Encrypt renewal was excluded from that validation.

Port bjss/AzureTRE-CGI#84 at b5a51d2f0968577c7483ef2d1c1e44f3b7bcd72c onto current upstream main.

Co-authored-by: Jay W <40270505+JayDoubleu@users.noreply.github.com>
@maxmartin-cgi

Max Martin (maxmartin-cgi) commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator Author

Local pre-commit hooks, actionlint syntax/expression checks and all 290 GitHub-script tests under Node.js 24.22.2 passed for the current revision, 3c077cca37deb6f20fb0f457d7d3f5274899abd7. No live Azure deployment was dispatched for this revision.

The historical CI and live Azure results below assessed 4e2d49cda2c6005c41ef722b70cd9272171a8620. They have not been repeated after applying these changes to the newer main base, 592cb621ef6965af59c323934f08e7468b1bafe7, and do not establish live validation of the current PR head. Temporary dispatch/filter adapters exercised the changed workflow definitions on Ubuntu 26.04. Earlier comment-bot runs checked merge 145c5a3 using main workflow definitions on Ubuntu 24.04; the direct branch deployment checked 4e2d49c on Ubuntu 26.04.

Plan item Result and evidence
1. PR checks, all path filters enabled Forced-path validation passed (290 script, 445 deployment, 23 Bookworm tests; Terraform, Bandit, docs and template checks). All 33 build targets, 1,821 unit tests on repeat, Ubuntu 26.04 publication, and five full Terraform tag scans passed. Existing head-specific runs passed four CodeQL languages, 255 E2E-helper tests, and 125 RP/Porter tests.
2. PR smoke deployment Existing /test run passed 23 smoke tests using main workflow definitions. The new pinned-runner branch deployment also passed all 23 smoke tests on Ubuntu 26.04.
3. Extended/E2E matrix and SQL validation Existing extended run passed three extended cases. SQL validation passed its one selected case on Ubuntu 26.04 (75 minutes), including private-DNS querying at S1 and data preservation through S1-to-S2 upgrade.
4. PR-environment destruction PR destruction job passed on Ubuntu 26.04 and removed the PR management/core resource groups. Queued branch cleanup was cancelled to allow the deployment retry; final cleanup is reported below.
5. Branch deployment and destruction Branch workflow, attempt 2 passed management, image builds/pushes, core, bundles, shared services, UI, smoke, SQL matrix and summary. Final branch destruction passed, removing its management/core groups synchronously.
6. Cleanup validation Validate-only run passed 445 guard tests and all 14 live checks. Disposable groups were deleted and non-fixture inventory was unchanged. Normal cleanup and plan mode were not dispatched.
7. CLI packaging CLI build passed installation/help checks and built the wheel/source distribution. Artifact upload matched no files: configured dist/tre-*.whl differs from actual cli/dist/azure_tre_cli-0.2.13-*.whl. The workflow was restored to its original disabled state.

Retries and limits:

  • The first UI process exited nonzero despite 453 passing JUnit assertions. A diagnostic and the unmodified repeat both passed. The initial exit remains unexplained; no failure was waived or suppressed.
  • Attempt 1 failed before one registration action started: GitHub could not resolve the pinned azure/login commit. Attempt 2 recovered registration and SQL validation without a code/pin change.
  • An optional full-codebase scan found SC2153 warnings/missing executable bits outside this PR and a corrected adapter style warning. Normal changed-file linting and forced-path checks passed.
  • The earlier branch attempt failed during blob-readiness lease release. This deployment reused the retained management storage; its readiness check passed, but it does not establish a fresh first-time storage bootstrap.
  • Let's Encrypt renewal was excluded by the issue's test plan. No CLI artifact was uploaded because its configured path matched no files.

Both PR and branch test environments were removed. Temporary validation branches/worktrees were removed; PR code and its branch were preserved.

@maxmartin-cgi
Max Martin (maxmartin-cgi) requested a review from a team as a code owner October 30, 2026 16:55
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit abe51df.

♻️ This comment has been updated with latest results.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Maintainer review is needed because live Azure validation predates the current head and certificate renewal remains untested on Ubuntu 26.04 with the preinstalled Azure CLI.

No open issues 🎉

What changed in this PR

Addresses #5273 by pinning Azure TRE’s GitHub Actions runners, preventing image changes caused by the moving ubuntu-latest label, and fixing certificate-renewal setup.

Changes:

  • Pin jobs using ubuntu-latest and the CodeQL job to ubuntu-26.04, retaining the three ubuntu-slim jobs.
  • Allow the new runner label in actionlint.
  • Use the preinstalled Azure CLI for certificate renewal, refresh the apt index before installing dependencies, and document the fixes.
File Description
CHANGELOG.md Record the runner and certificate-workflow fixes.
.github/​workflows/​test_results.yml Pin the test-results runner.
.github/​workflows/​resource_processor_tests.yml Pin the resource-processor test runner.
.github/​workflows/​pr_comment_bot.yml Pin environment preparation and destruction runners.
.github/​workflows/​lets_encrypt.yml Pin the runner, remove the Azure CLI install, and refresh apt.
.github/​workflows/​e2e_helper_tests.yml Pin the E2E helper test runner.
.github/​workflows/​deploy_tre_reusable.yml Pin deployment, bundle, and E2E runners.
.github/​workflows/​deploy_tre_branch.yml Pin the branch-preparation runner.
.github/​workflows/​codeql-analysis.yml Move CodeQL from Ubuntu 22.04 to 26.04.
.github/​workflows/​cli-package.yml Pin the CLI packaging runner.
.github/​workflows/​clean_validation_envs.yml Pin cleanup and validation runners.
.github/​workflows/​build_validation_develop.yml Pin the lint runner.
.github/​workflows/​build_docker_images.yml Pin the image-build runner.
.github/​workflows/​build_all_dockerfiles.yml Pin discovery, build, and summary runners.
.github/​linters/​actionlint.yml Allow the ubuntu-26.04 runner label.

Review effort: Balanced

Jay W (JayDoubleu) added a commit to bjss/AzureTRE-CGI that referenced this pull request Nov 1, 2026
The ubuntu-latest label moves to Ubuntu 26 from 19 October 2026. The actionlint lines are the same as in microsoft/AzureTRE#5285, so a later sync of main applies them without a conflict.
@ChrisChapman-gh

Copy link
Copy Markdown
Collaborator

/test

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/41667782266

(in response to this comment from Chris Chapman (@ChrisChapman-gh))

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflows depend on the ubuntu-latest label, which moves to Ubuntu 26.04

4 participants