Repository navigation
Fix VM size defaults, package sources, storage network rules and script traces #5290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jay W (JayDoubleu)
wants to merge
33
commits into
microsoft:main
Choose a base branch
from
JayDoubleu:fix/vm-sizes-and-network-limits
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
9d668e3
Use VM size defaults that Switzerland North offers
JayDoubleu 41c5216
Wrap a long CHANGELOG entry
JayDoubleu d38e0d1
Use the Ubuntu archive key and HTTPS for the Ubuntu packages
JayDoubleu cdbb7f0
Create the Gitea storage network rules with the account
JayDoubleu 4a66666
Create the workspace storage network rules with the account
JayDoubleu 2738e4a
Create the Airlock export in-progress network rules with the account
JayDoubleu c371119
Change the versions of the workspace bundles that use the base
JayDoubleu 54cfeb3
Wrap a long CHANGELOG entry
JayDoubleu d031de9
Turn off the shell command trace in two Guacamole scripts
JayDoubleu d1df0fd
Limit the core storage account to its private endpoints
JayDoubleu 4dc93ec
Update the Airlock notifier Logic App in one request
JayDoubleu c3c3c09
Describe what an earlier notifier does after the core change
JayDoubleu 982ac10
Use one version bump for each component
JayDoubleu b77258f
Keep the admin VM size on upgrade and add upgrade notes
JayDoubleu da848a8
Make the guard tests find more forms
JayDoubleu 4dbf84e
Run the guard tests when the files that they read change
JayDoubleu b07a7f4
Set core 0.19.0 for the core storage change
JayDoubleu 4f6f92b
Find more trace forms and the notifier provider version in the guard …
JayDoubleu f8ba663
Name the Nexus upgrade and a completed upgrade in the upgrade notes
JayDoubleu 997b3a4
Add a report of VM sizes and their availability in Azure regions
JayDoubleu c2059b3
Skip database SKUs that a tier label maps in the VM size report
JayDoubleu 0aa2ea1
Run the VM size report on a branch push that changes VM sizes
JayDoubleu db34bc6
Fix six points in the VM size report and its workflow
JayDoubleu 0771c9d
Run the VM size report on ubuntu-26.04 and allow the label in actionlint
JayDoubleu f9e3adb
Fix three points in the VM size report and the trace guard
JayDoubleu 019a77f
Run the VM size report by hand only
JayDoubleu db5374c
Find lowercase VM sizes and ignore set -x in comments and quoted text
JayDoubleu cbbc4a1
Read quotes and comments as the shell does in the trace guard
JayDoubleu 0ac9074
Keep quoted and escaped separators as words in the trace guard
JayDoubleu 2ccfc6c
Add the issue and pull request links to the new CHANGELOG entries
JayDoubleu aff8f69
Describe the values that earlier Guacamole versions wrote to their logs
JayDoubleu 77e8b32
Link the new issues in the CHANGELOG entries
JayDoubleu 18912ac
Say that the admin VM size applies only at install, and give a rollba…
JayDoubleu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| --- | ||
| name: VM Size Availability | ||
|
|
||
| on: # yamllint disable-line rule:truthy | ||
| workflow_dispatch: | ||
| inputs: | ||
| region: | ||
| description: >- | ||
| Region: the Azure region to check. ci-location is the LOCATION variable of the CICD environment. | ||
| Select none to check only the regions in More regions. | ||
| type: choice | ||
| default: ci-location | ||
| options: | ||
| - ci-location | ||
| - switzerlandnorth | ||
| - switzerlandwest | ||
| - uksouth | ||
| - ukwest | ||
| - westeurope | ||
| - northeurope | ||
| - swedencentral | ||
| - norwayeast | ||
| - germanywestcentral | ||
| - francecentral | ||
| - italynorth | ||
| - polandcentral | ||
| - spaincentral | ||
| - eastus | ||
| - eastus2 | ||
| - centralus | ||
| - westus2 | ||
| - westus3 | ||
| - canadacentral | ||
| - australiaeast | ||
| - japaneast | ||
| - southeastasia | ||
| - centralindia | ||
| - southafricanorth | ||
| - brazilsouth | ||
| - uaenorth | ||
| - none | ||
| more_regions: | ||
| description: "More regions: other Azure regions to check, separated by commas. For example uksouth,eastus2" | ||
| type: string | ||
| required: false | ||
| default: "" | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| report: | ||
| name: Report VM size availability | ||
| runs-on: ubuntu-26.04 | ||
| # The federated credential of the CI identity trusts this environment. | ||
| environment: CICD | ||
| timeout-minutes: 15 | ||
| permissions: | ||
| contents: read | ||
| # Log in to Azure with OIDC. | ||
| id-token: write | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Azure Login | ||
| uses: azure/login@532459ea530d8321f2fb9bb10d1e0bcf23869a43 # v3.0.0 | ||
| with: | ||
| client-id: ${{ secrets.AZURE_CLIENT_ID }} | ||
| tenant-id: ${{ secrets.AZURE_TENANT_ID }} | ||
| subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }} | ||
| environment: ${{ vars.AZURE_ENVIRONMENT || secrets.AZURE_ENVIRONMENT || 'AzureCloud' }} | ||
|
|
||
| - name: Report VM size availability | ||
| env: | ||
| REGION: ${{ inputs.region }} | ||
| MORE_REGIONS: ${{ inputs.more_regions }} | ||
| CI_LOCATION: ${{ vars.LOCATION }} | ||
| LINK_BASE: ${{ github.server_url }}/${{ github.repository }}/blob/${{ github.sha }} | ||
| run: | | ||
| case "$REGION" in | ||
| none) regions="$MORE_REGIONS" ;; | ||
| ci-location) | ||
| if [ -z "$CI_LOCATION" ]; then | ||
| echo "::error::The CICD environment has no LOCATION variable. Select a region." | ||
| exit 1 | ||
| fi | ||
| regions="$CI_LOCATION,$MORE_REGIONS" | ||
| ;; | ||
| *) regions="$REGION,$MORE_REGIONS" ;; | ||
| esac | ||
| if [ -z "${regions//[, ]/}" ]; then | ||
| echo "::error::Select a region, or type one or more regions in More regions." | ||
| exit 1 | ||
| fi | ||
| # The artifact is public on a public repository, so keep subscription data out of the report. | ||
| python3 devops/scripts/vm_size_report.py --region "$regions" --hide-subscription \ | ||
| --link-base "$LINK_BASE" --output vm-size-report.md | ||
| cat vm-size-report.md >> "$GITHUB_STEP_SUMMARY" | ||
|
|
||
| - name: Upload the report | ||
| uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0 | ||
| with: | ||
| name: vm-size-report | ||
| path: vm-size-report.md | ||
| if-no-files-found: error | ||
| retention-days: 7 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| __version__ = "0.18.16" | ||
| __version__ = "0.19.0" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.