Update test framework: add granular tests, remove unstandardized tests, and document known variations#537
Open
ryan-syed wants to merge 16 commits intomicrosoft:masterfrom
Open
Conversation
… Value functions and other scenarios - Implemented GroupByWithListAverage query to calculate average LocationID by Borough. - Added output for GroupByWithListAverage to validate results. - Created GroupByWithListMinMax query to find max and min values for Zone and LocationID by Borough. - Added output for GroupByWithListMinMax to validate results. - Developed GroupByWithListMinMaxDateTime query to find max and min pickup datetime by PULocationID. - Added output for GroupByWithListMinMaxDateTime to validate results. - Implemented GroupByWithTableRunCount query to count occurrences of Zones. - Added output for GroupByWithTableRunCount to validate results. - Created ValueFunctions query to test various mathematical operations on passenger_count and total_amount. - Added output for ValueFunctions to validate results.
…y example to include NycTaxiGreenDate
KazimMir
reviewed
Mar 25, 2026
Member
KazimMir
left a comment
KazimMir
left a comment
There was a problem hiding this comment.
Provided a few comments to address
| # Ensure the credentials are setup for your connector following the instructions here: https://learn.microsoft.com/power-query/power-query-sdk-vs-code#set-credential | ||
|
|
||
| # Retrieving the settings for running the TestSuites from the JSON settings file | ||
| $RunPQSDKTestSuitesSettings = Get-Content -Path RunPQSDKTestSuitesSettings.json | ConvertFrom-Json |
Member
There was a problem hiding this comment.
Consider using $PSScriptRoot to make it more robust.
Suggested change
| $RunPQSDKTestSuitesSettings = Get-Content -Path RunPQSDKTestSuitesSettings.json | ConvertFrom-Json | |
| $RunPQSDKTestSuitesSettings = Get-Content -Path (Join-Path $PSScriptRoot "RunPQSDKTestSuitesSettings.json") | ConvertFrom-Json``` |
Comment on lines
354
to
359
| switch ($_.OutputStatus) { | ||
| { $_ -eq "Passed" } { $color = "$($PSStyle.Foreground.Green)" } | ||
| { $_ -eq "Output File Generated" } { $color = "$($PSStyle.Foreground.Green)" } | ||
| { $_ -eq "Failed" } { $color = "$($PSStyle.Foreground.Red)" } | ||
| { $_ -eq "Error" } { $color = "$($PSStyle.Foreground.Yellow)" } | ||
| } |
Member
There was a problem hiding this comment.
Consider adding a default
Suggested change
| switch ($_.OutputStatus) { | |
| { $_ -eq "Passed" } { $color = "$($PSStyle.Foreground.Green)" } | |
| { $_ -eq "Output File Generated" } { $color = "$($PSStyle.Foreground.Green)" } | |
| { $_ -eq "Failed" } { $color = "$($PSStyle.Foreground.Red)" } | |
| { $_ -eq "Error" } { $color = "$($PSStyle.Foreground.Yellow)" } | |
| } | |
| switch ($_.OutputStatus) { | |
| { $_ -eq "Passed" } { $color = "$($PSStyle.Foreground.Green)" } | |
| { $_ -eq "Output File Generated" } { $color = "$($PSStyle.Foreground.Green)" } | |
| { $_ -eq "Failed" } { $color = "$($PSStyle.Foreground.Red)" } | |
| { $_ -eq "Error" } { $color = "$($PSStyle.Foreground.Yellow)" } | |
| default { $color = "" } | |
| } |
mattmasson
approved these changes
Mar 25, 2026
Co-authored-by: Kazim Mir <kazim.mir@improving.com>
…m/ryan-syed/DataConnectors into dev/ryan-syed/UpdateTestFramework
Contributor
Author
|
@mattmasson I don't have write access. Could you please merge the changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the PQ SDK Test Framework with granular tests, removes tests that need further
standardization, and adds documentation for known test variations across connectors.
Changes
Test updates
Tests removed (18 tests, pending standardization)
Removed tests that fail across multiple connectors due to test design issues, not connector bugs.
These will be re-added after standardization in the private repo:
Documentation
Test runner