Skip to content

[SPIR-V] Fix layout rule propagation for function variable and parameter aliasing for ConstantBuffer and TextureBuffer.#8326

Merged
luciechoi merged 2 commits intomicrosoft:mainfrom
luciechoi:descriptorheap
Apr 10, 2026
Merged

[SPIR-V] Fix layout rule propagation for function variable and parameter aliasing for ConstantBuffer and TextureBuffer.#8326
luciechoi merged 2 commits intomicrosoft:mainfrom
luciechoi:descriptorheap

Conversation

@luciechoi
Copy link
Copy Markdown
Collaborator

Fixes #8244

There are 2 issues being fixed:

  • Layout rule for resources should be propagated when aliased through function variable. (above issue)
  • Fix the incorrect layout rule propagation for ConstantBuffer vs TextureBuffer when creating function parameter.

Comment thread tools/clang/test/CodeGenSPIRV/type.texture-buffer.pass.hlsl
@luciechoi luciechoi requested a review from Keenuts April 2, 2026 13:13
Copy link
Copy Markdown
Collaborator

@s-perron s-perron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread tools/clang/test/CodeGenSPIRV/type.texture-buffer.fn-var.hlsl Outdated
@luciechoi luciechoi requested a review from s-perron April 2, 2026 14:28
@luciechoi luciechoi enabled auto-merge (squash) April 2, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[SPIR-V] generated SPIR-V is invalid: Result type (OpTypeStruct) does not match the type that results from indexing into the composite (OpTypeStruct).

3 participants