-
Notifications
You must be signed in to change notification settings - Fork 12
perf: cache resolved instance functions to avoid repeated lookups in deep hierarchies #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hectorhdzg
merged 2 commits into
microsoft:main
from
hectorhdzg:fix/deep-hierarchy-perf-cache
May 20, 2026
+620
−17
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there is one thought around this PR and the class one, in that by caching the "lookups" this would break the previous capability (but not sure if we actual use this today) of dynamically adjusting to change on base classes.
Generally, we build "on-top" of the items (extending / changing features) for new base classes, so this caching should be fine as I can't currently thing of any specific issues...
But we should probably test locally before releasing an updated version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7 new re-registration tests
Re-calling dynamicProto on the same instance updates the resolved function (not stale)
Re-registration on one instance doesn't affect other instances
Child class with setInstFuncs: true — base proxy is early-bound (re-registration doesn't propagate)
Child class with setInstFuncs: false — base proxy is late-bound through the dynamic proxy (re-registration IS visible)
Multiple dynamicProto calls in a single constructor — last registration wins