perf: cache prototype chain walk to reduce construction from O(M*D) to O(M)#109
Merged
hectorhdzg merged 1 commit intoMay 19, 2026
Merged
Conversation
…o O(M)
_getBaseFuncs() previously re-walked the entire prototype chain on every
instance creation, costing O(M*D) for M methods and D inheritance depth.
This adds _getBaseProtoFuncs() which caches the {funcName -> sourceProto}
mapping on the class prototype (own property) after the first walk. All
subsequent instance constructions reuse the cached mapping and only create
per-instance proxy closures in O(M) time.
Key detail: uses objHasOwnProperty to check cache presence, preventing
child classes from accidentally inheriting a parent's cache through the
prototype chain.
Adds comprehensive test suite (DynamicProtoCache.Tests.ts) validating:
- Multi-instance correctness with shared cache
- Sibling classes with independent caches
- Deep 3-level dynamic chains
- Non-dynamic classes sandwiched between dynamic classes
- Many-method resolution
- Stress test with 50 rapid instances
rads-1996
approved these changes
May 18, 2026
MSNev
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_getBaseFuncs() previously re-walked the entire prototype chain on every instance creation, costing O(M*D) for M methods and D inheritance depth.
This adds _getBaseProtoFuncs() which caches the {funcName -> sourceProto} mapping on the class prototype (own property) after the first walk. All subsequent instance constructions reuse the cached mapping and only create per-instance proxy closures in O(M) time.
Key detail: uses objHasOwnProperty to check cache presence, preventing child classes from accidentally inheriting a parent's cache through the prototype chain.
Adds comprehensive test suite (DynamicProtoCache.Tests.ts) validating: