Repository navigation
feat(web): enable download for interactive view HTML nodes (#427) - #434
Open
Yuqing (mydmdm) wants to merge 1 commit into
Open
Yuqing (mydmdm) wants to merge 1 commit into
Yuqing (mydmdm) wants to merge 1 commit into
Conversation
Allow HTML-backed Web nodes that carry `data.interactiveView` metadata (including RFS-published HTML decks/reports and interactive HTML bundles) to expose Download in both the Preview Workspace header and Canvas `...` overflow menu, resolving suggested filenames from `data.label` with `.html` extension while keeping snapshot-less external URLs excluded. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #430 for #427:
data.interactiveViewexclusion incanDownloadWebSource/resolveWebDownloadTargetso HTML-backedwebnodes (including RFS-published standalone HTML decks/reports and Interactive View.htmlartifacts) expose Download in both the Preview Workspace top header (WebPreview) and the Canvas…overflow menu (WebNode).data.labelstrictly as an optional filename stem hint while preserving.html/.mhtmlextensions from the stored artifact key (e.g.,HUABU · Impact Pitch · Complete Deck->HUABU · Impact Pitch · Complete Deck.html).docs/architecture/preview-workspace.md.Validation
pnpm --filter @huabu/web exec vitest run src/utils/__tests__/nodeDownload.test.ts src/components/Nodes/nodeDownloadSurfaces.test.tsx src/components/Nodes/web/WebNode.reading.test.tsxpnpm formatpnpm lint:fixpnpm typechecknode scripts/check-headers.mjs