Skip to content

feat(web): enable download for interactive view HTML nodes (#427) - #434

Open
Yuqing (mydmdm) wants to merge 1 commit into
alphafrom
fix/issue-427
Open

Yuqing (mydmdm) wants to merge 1 commit into
alphafrom
fix/issue-427

Conversation

@mydmdm

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #430 for #427:

  • Lift the data.interactiveView exclusion in canDownloadWebSource / resolveWebDownloadTarget so HTML-backed web nodes (including RFS-published standalone HTML decks/reports and Interactive View .html artifacts) expose Download in both the Preview Workspace top header (WebPreview) and the Canvas … overflow menu (WebNode).
  • Keep data.label strictly as an optional filename stem hint while preserving .html / .mhtml extensions from the stored artifact key (e.g., HUABU · Impact Pitch · Complete Deck -> HUABU · Impact Pitch · Complete Deck.html).
  • Continue excluding snapshot-less external URLs and missing files.
  • Update unit/surface tests and docs/architecture/preview-workspace.md.

Validation

  • pnpm --filter @huabu/web exec vitest run src/utils/__tests__/nodeDownload.test.ts src/components/Nodes/nodeDownloadSurfaces.test.tsx src/components/Nodes/web/WebNode.reading.test.tsx
  • pnpm format
  • pnpm lint:fix
  • pnpm typecheck
  • node scripts/check-headers.mjs

Allow HTML-backed Web nodes that carry `data.interactiveView` metadata
(including RFS-published HTML decks/reports and interactive HTML bundles)
to expose Download in both the Preview Workspace header and Canvas `...`
overflow menu, resolving suggested filenames from `data.label` with `.html`
extension while keeping snapshot-less external URLs excluded.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant