Skip to content

Fix the easy cloud first-use findings from #435 - #438

Open
Yuge Zhang (ultmaster) wants to merge 10 commits into
microsoft:mainfrom
ultmaster:fix/issue-435-easy-fixes
Open

Yuge Zhang (ultmaster) wants to merge 10 commits into
microsoft:mainfrom
ultmaster:fix/issue-435-easy-fixes

Conversation

@ultmaster

@ultmaster Yuge Zhang (ultmaster) commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fixes the six items the #435 triage classed as easy to fix, one commit each:

Item Commit Change
HUABU-CLOUD-14 (P2) history details 404 fix(agent): carry the history turn reference in the query GET /api/agent/history/:threadId/turn now takes turnRef as a bounded query parameter (max 4096, like the page before cursor). A real cursor is ~130 characters and Fastify's path-parameter limit is 100, so the request never reached the handler. No global router limit change.
HUABU-CLOUD-10 (P1) Undici dispatcher mismatch fix(server): pair the guarded transport's undici with Node's fetch Pins undici to ^7.30.2. The guarded member transport hands an npm-undici Agent to Node's built-in fetch, and undici 8's Agent rejects Node 24's handlers (invalid onRequestStart method). The major came from the Dependabot bump in #346, not #428. 7.30.2 has no known advisories and keeps native fetch/FormData, so the multipart realm fix in setup-proxy.ts is untouched.
HUABU-CLOUD-08 (P2) Loading flash on every focus fix(web): keep the app visible while re-verifying identity on focus focus + visibilitychange on one return share one identity check. While a running session is re-verified, the app stays visible under a clear, input-blocking cover (app root still inert); a check over 1s shows a small "Checking your session…" notice. The full loading screen is kept for initial load. Account-change, sign-out, revocation and draft-replay handling are unchanged.
HUABU-CLOUD-04 (P2) unconfigured New conversation fix(web): lead an unconfigured New conversation into setup New conversation now uses the shared setup toast, whose actions are Configure model (picks Built-In Pi, retries the start, opens its provider settings) and Connect device (opens Settings → Devices and Agents), reusing useSettingsUiStore.open. The requested Chat opens behind Settings, so it is waiting when Settings closes.
HUABU-CLOUD-05 (P2) Workspace naming and rename Name the first Workspace Default and let managers rename Workspaces A new SQL deployment's first Workspace is named Default (existing rows are untouched; the default is found by recency, not name). Descriptors carry an optional canManage decided by the same rules as PATCH/DELETE. The chooser has inline rename for manageable Workspaces. A named Workspace's header label is its name plus a chevron instead of "Workspace: Workspace".
HUABU-CLOUD-01 (P2) admission discoverability Show waiting people how to be admitted and label service access The waiting screen tells the person exactly what an administrator does (Settings → People → Service access). People settings label the switch "Service access", show Administrator / Has access / Waiting for access badges, and explain that a Workspace grant does not admit anyone and starts as Viewer.

Not included: the easy half of 07 (deployed revision, pinned checkout, shell default), which is in its own PR, and all need-discussion or deferred items.

Behaviour changes to review

  • The history-turn endpoint path changes (/turn/:turnRef → /turn?turnRef=). The web client and server ship together; no other caller was found.
  • New SQL deployments name their first Workspace "Default". Existing "Workspace" rows keep their name and can now be renamed from the chooser.
  • The personal Workspace name stays <display name>'s Workspace, with Workspace capitalized as the product term.

Verification

  • pnpm run lint (0 errors), format:check, typecheck, check:i18n, check-headers, and pnpm run test across all packages pass.
  • 14: route test with an encoded production-length cursor (UUID thread, >100 chars) reaches the handler. Also covers missing/over-limit turnRef (400), malformed (400), stale (409), missing turn (404), and Space-access scoping.
  • 10: the outbound tests previously only asserted that guarded requests throw, which the dispatcher error also satisfied. They now require the guard's own NON_PUBLIC_ADDRESS refusal and check that the npm undici major matches process.versions.undici. With undici 8 restored, 4 of these tests fail; with 7.30.2 all pass. Live check on Node 24.16.0 (the Dockerfile's base): a guarded GET to a public host and a guarded multipart POST both return 200, and 169.254.169.254 is still refused with NON_PUBLIC_ADDRESS.
  • 08, 04, 05, 01: unit tests added for each, covering one check per return, the slow-check notice, the setup toast actions and retry, canManage and rename for Bubble owner vs. Viewer, the chooser rename, and People badges and switch.

Browser verification

Real browser (Playwright/Chromium) against a local Bubble-mode server on this branch, using the deployment's real Auth0 and Entra authenticators from .env, Postgres structured storage in a disposable container, and an isolated data dir. Test accounts were created for this: an Entra owner in the tenant (via az, with an authenticator-app MFA registration) and an Auth0 member (via the Management API). Each signed in through the real provider login in its own browser context. An earlier pass with Bubble's loopback default driver gave the same results.

  • 01: after real Entra sign-in, the owner-to-be saw the new No access copy, and once provisioned as owner the waiting tab opened by itself. The Auth0 member saw the same copy. The owner's People tab showed the intro text, Administrator / Waiting for access badges and labelled Service access switches (Service access: Huabu 435 Member). Turning on the member's access opened the member's waiting tab into the app without a reload, in a new personal Workspace named Huabu 435 Member's Workspace.
  • 05: the first Workspace on Postgres structured storage is "Default" with canManage: true for the owner, and the header shows the name with a chevron. The member renamed their Workspace from the chooser; it survived reload. After the owner added the member to "Default" (Viewer) from People, the member's chooser showed "Default" without a rename control, the API reported canManage: false, and a direct PATCH returned 404.
  • 04: with no model or device, the member's New conversation showed the new toast. Connect device opened Devices and Agents. Configure model opened Built-In Pi's provider settings with the new Chat behind it.
  • 10: an Auth0 member, whose requests go through the guarded transport, configured Built-In Pi with the OpenAI provider, a custom public base URL and model gpt-6.2-sol. "Reply with exactly: pong 435" got the model's reply pong 435. With a deliberately invalid Azure OpenAI key the member got Azure's own 401, so failures surface from the provider rather than from the transport. In the earlier pass, with undici 8 temporarily restored, a member request failed with the audit's exact error ("Connection error. This may be caused by passing an undici dispatcher … incompatible with the fetch implementation"); restoring undici 7 brought the provider's response back.
  • 14: the member's real persisted turn has a 130-character reference (the length seen in the audit). It returned the turn (200) through ?turnRef=. The old path form reproduces the audit's Route GET:… not found 404. The owner, whose current Workspace does not hold that Space, got Canvas not found 404.
  • 08: on the Entra owner's session, three bursts of focus + visibilitychange + pageshow made one identity request. With identity delayed by 2.5s, the app and the open Settings dialog stayed visible under the clear cover, with no full-page Loading screen; a click during the check did not close Settings; "Checking your session…" appeared after 1s; the cover cleared when the check finished. In the earlier pass, switching the tab's session cookie to another principal still did the existing full reload into the new account.

Review follow-ups

  • The first CI run failed in the Postgres storage contract, which still expected a first Workspace named "Workspace". It is fixed in 2b85f17, and the full storage suite (test:storage-backends, 562 tests) now passes locally against containers.
  • Copilot review: the setup toast's retry now also checks the initiating Workspace (8a83dea); the rename field ignores IME composition keys (54dee0d); listing Workspaces decides canManage in one canMany batch (41c8742); the People e2e spec uses the new Service access label (2b85f17).

Not verified

  • Nothing was deployed or run against the cloud pilot.
  • No real Edge focus events. Foreground returns were dispatched as DOM events in Chromium.

Refs #435

🤖 Generated with Claude Code

)

A real turn reference is base64url JSON naming the thread's UUID, about
130 characters, but Fastify rejects path parameters longer than 100, so
loading historical tool details fell through to the web shell's
not-found handler. The reference now travels as a bounded `turnRef`
query parameter, like the page `before` cursor, and the route test uses
a production-length cursor.

Fixes HUABU-CLOUD-14.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…icrosoft#435)

Member model requests hand an Agent from the npm `undici` package to
Node's built-in fetch, so the two must share a major version. The
Dependabot bump to undici 8 (microsoft#346) broke that: undici 8's Agent rejects
the handlers Node 24's fetch passes (`invalid onRequestStart method`),
so every personal Built-In Pi request on a cloud deployment failed.

Pin undici to ^7.30.2, matching Node 24's bundled major and free of
known advisories. Native fetch stays in place, so the realm-aligned
FormData the OpenAI SDK needs for multipart uploads is unaffected.

The outbound tests only asserted that guarded requests throw, which the
dispatcher error also satisfied. They now require the guard's own
NON_PUBLIC_ADDRESS refusal and check the undici/Node major pairing.

Fixes HUABU-CLOUD-10.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…icrosoft#435)

Returning to a running Bubble tab fires both `focus` and
`visibilitychange`, and each one blocked the app and covered it with the
near-opaque full-page loading screen while a fresh identity check ran
(HUABU-CLOUD-08).

- Coalesce foreground checks: an event joins a foreground check that is
  still the deciding one. A later check or a peer's cookie write
  supersedes it, so the next event checks again.
- While re-verifying, keep the app visible under a clear cover that still
  catches pointer input (the app root stays inert, as before). A check
  that outlasts one second shows a small "Checking your session…" notice.
  The full loading screen is reserved for initial loading.

Account-change, sign-out, revocation and draft-replay handling are
unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…#435)

HUABU-CLOUD-04. The New conversation button reported a missing Agent as a
danger toast with only Dismiss, unlike the question-node and PDF paths that
already offered setup. It now uses the same setup toast, and that toast
offers the two setup paths by name:

- Connect device opens Settings at Devices and Agents.
- Configure model records Built-In Pi as the explicit choice, retries the
  start (no model request is sent), and opens Built-In Pi's provider
  settings, so the requested Chat is waiting when Settings closes.

A retry from a toast that outlived its Space does nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A SQL deployment's first Workspace was named "Workspace", so the header
read "Workspace: Workspace", and the UI had no way to rename it even
though the server already accepts PATCH /api/workspaces/:workspaceId.

- New SQL deployments name their first Workspace "Default". The default
  is found by recency, not name, so existing deployments keep theirs.
- Workspace descriptors from the list, get and rename routes carry
  `canManage`, decided by the same rules as PATCH and DELETE (manage
  grant for a Bubble person, localhost outside managed mode otherwise).
- The Workspace chooser offers an inline rename for those Workspaces;
  the new name updates the chooser row and, for the active one, the
  header.
- A named Workspace's header label is its name with a chevron instead
  of a "Workspace:" prefix.

Part of microsoft#435 (HUABU-CLOUD-05).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A new account that is signed in but not admitted was told only to ask an
administrator, and the administrator's People list had a small unlabeled
switch with Workspace roles beside it, so it was not clear which control
admits someone.

- The "No access yet" screen spells out the administrator's path
  (Settings → People → Service access), notes that the account is
  already listed, and that the page opens once access is on.
- People settings label the switch "Service access", show each person
  as Administrator, Has access or Waiting for access, and explain that
  adding someone to a Workspace does not admit them and starts them as
  a Viewer.

Part of microsoft#435 (HUABU-CLOUD-01).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 10:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The persistent toast’s retry can create a Chat in the wrong Workspace after a switch because it checks only the Space ID, not the originating Workspace ID.

4 open issues
1 file not reviewed
  • pnpm-lock.yaml: Generated file
What changed in this PR

Addresses six first-use issues from #435 across cloud history access, guarded requests, session checks, conversation setup, Workspace management, and admission guidance.

Changes:

  • Moves history-turn references into query parameters and aligns the server’s Undici dependency with Node’s built-in fetch.
  • Keeps the app visible during session verification and adds actionable conversation-setup choices.
  • Adds Workspace renaming, clearer default naming, and explicit service-access guidance, with regression tests.
File Description
pnpm-lock.yaml Resolves server Undici to 7.30.2.
packages/​shared/​src/​types/​api/​workspace.ts Adds optional Workspace management capability.
packages/​shared/​src/​types/​api/​agent-history.ts Moves bounded turn references into query validation.
docs/​architecture/​api-design.md Documents the revised history-turn endpoint.
apps/​web/​src/​store/​workspaceStore.ts Adds rename requests and local name updates.
apps/​web/​src/​store/​previewWorkspace/​actions.ts Offers setup actions when Chat creation lacks an Agent.
apps/​web/​src/​store/​canvasStore.postCreateEditing.test.ts Tests setup actions and Chat retry behavior.
apps/​web/​src/​store/​acpProfilesStore.ts Routes setup choices to model or device settings.
apps/​web/​src/​store/​acpProfilesStore.test.ts Tests setup-toast actions.
apps/​web/​src/​pages/​WorkspaceSetupPage.tsx Adds inline renaming for manageable Workspaces.
apps/​web/​src/​pages/​WorkspaceSetupPage.test.tsx Tests rename visibility and submission.
apps/​web/​src/​pages/​CanvasListPage.tsx Simplifies named-Workspace labels and adds a chevron.
apps/​web/​src/​i18n/​resources/​zh-CN/​common.json Adds Chinese setup, rename, and access copy.
apps/​web/​src/​i18n/​resources/​en/​common.json Adds English setup, rename, and access copy.
apps/​web/​src/​components/​Shell/​SignInGate.tsx Deduplicates pending foreground checks and uses a transparent cover.
apps/​web/​src/​components/​Shell/​SignInGate.test.tsx Tests verification deduplication and delayed notices.
apps/​web/​src/​components/​Settings/​sections/​PeopleSettings.tsx Labels service access and displays admission badges.
apps/​web/​src/​components/​Settings/​sections/​PeopleSettings.test.tsx Tests access labels, badges, and toggling.
apps/​web/​src/​api/​workspace.ts Adds the Workspace rename client helper.
apps/​web/​src/​api/​_routes.ts Builds history-turn URLs with query parameters.
apps/​server/​src/​modules/​workspaces.route.ts Includes management permissions in Workspace descriptors.
apps/​server/​src/​modules/​workspaces.route.test.ts Tests local and managed permission descriptors.
apps/​server/​src/​modules/​workspaces.route.access.test.ts Tests owner and Viewer rename permissions.
apps/​server/​src/​modules/​storage/​storage.workspaces.remote.test.ts Expects “Default” for the first SQL Workspace.
apps/​server/​src/​modules/​storage/​storage.ts Names new SQL deployments’ first Workspace “Default”.
apps/​server/​src/​modules/​security/​space-access.test.ts Checks access scoping for the revised history route.
apps/​server/​src/​modules/​security/​outbound.ts Documents the Undici/native-fetch compatibility requirement.
apps/​server/​src/​modules/​security/​outbound.test.ts Checks version pairing and guard-specific refusals.
apps/​server/​src/​modules/​agent/​agent.route.ts Reads history-turn references from the query.
apps/​server/​src/​modules/​agent/​agent.history-page.route.test.ts Tests long cursors and invalid detail requests.
apps/​server/​package.json Sets the server’s Undici dependency to ^7.30.2.

Review effort: Balanced

"intro": "Who may use this Huabu, and which Workspaces they can open. People appear here after they first sign in. Changes apply on their next request.",
"administrator": "Administrator",
"access": "Access",
"serviceAccess": "Service access",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 2b85f17: the spec now locates the switch by en.people.serviceAccess. apps/web/e2e/member-settings.spec.ts passes locally (3/3).

@ultmaster

Copy link
Copy Markdown
Collaborator Author

Test coverage

Head tested: ebf1559b3c0e7276bf62d12d7a858ee0ed452b15 (all six commits).

Automated

  • The full pnpm run check passes: lint (0 errors), format, typecheck, unit and integration tests (server 3589, web 5789, plus the other packages), deployment tests, i18n, Space kits and headers.
  • New or updated tests, by item:
    • 14: route tests for the ?turnRef= form. They cover a missing reference (400), one over 4096 characters (400), a malformed one (400), and a production-length cursor built with encodeTurnCursor that reaches the handler. The Space access test moved to the new URL.
    • 10: the guard assertions now check for the NON_PUBLIC_ADDRESS refusal itself rather than any rejection, so an undici mismatch can no longer pass as a refusal. A new test checks that npm undici's major version matches Node's bundled undici (process.versions.undici).
    • 08: SignInGate tests. Foreground events are coalesced, the clear cover replaces the loading screen, and the notice appears after 1s.
    • 04: toast tests for the "Connect device" and "Configure model" actions, including the retry after Built-In Pi is chosen.
    • 05: route tests check that canManage follows the same rules as PATCH/DELETE, plus web tests for inline rename and the header label. The Postgres remote test now expects the default name "Default".
    • 01: a new PeopleSettings.test.tsx covers the badges and the labelled Service access switch, and SignInGate covers the new no-access copy.

Real browser

Playwright/Chromium against a local server on this branch: Bubble identity with the real Auth0 and Entra authenticators, Postgres structured storage (HUABU_STRUCTURED_BACKEND=postgres, as on the pilot) in a disposable container, and an isolated data dir. Test accounts were created for this (an Entra owner via az with authenticator-app MFA; Auth0 owner and member via the Management API). Each signed in through the real provider login in its own browser context.

Item Result
01 The new "No access yet" copy appears for both providers. People shows the intro, the Administrator / Waiting for access / Has access badges, and a labelled Service access: <name> switch. Turning access on opens the member's waiting tab without a reload, into Huabu 435 Member's Workspace. A waiting owner-to-be also opens once provisioned.
05 The first Workspace on Postgres is "Default" (canManage: true for the owner), and the header shows the name with a chevron. The member's rename survives reload. As a Viewer of "Default", the member sees no rename control, gets canManage: false, and a direct PATCH returns 404.
04 With no model and no device, New conversation shows the toast. Connect device opens Devices and Agents. Configure model opens Built-In Pi's provider settings with the chat behind it.
10 Requests from an Auth0 member go through the guarded transport. With an OpenAI-compatible endpoint and gpt-6.2-sol, "Reply with exactly: pong 435" got the reply pong 435. An invalid Azure OpenAI key got Azure's own 401. With undici 8 temporarily restored, the audit's exact "undici dispatcher … incompatible with the fetch implementation" error came back; undici 7 restored the provider response.
14 A real saved turn's 130-character reference returns 200 through ?turnRef=. The old path form reproduces the audit's Route GET:… not found 404. A principal whose Workspace doesn't hold the Space gets Canvas not found 404. A missing ordinal returns history_turn_not_found.
08 On a real Entra session, bursts of focus + visibilitychange + pageshow make one identity request. With identity delayed 2.5s, the app and the open Settings dialog stay visible under the clear cover, and no loading screen appears. A click during the check doesn't close Settings. "Checking your session…" appears after 1s, and the cover clears when the check finishes. Switching the session to another principal still triggers the existing full reload.

The undici 8 swap and the account-switch reload ran in an earlier pass with Bubble's loopback default driver. All other rows were rerun with the real sign-ins.

Not covered

  • Nothing was deployed or run against the cloud pilot.
  • Foreground returns were DOM events dispatched in Chromium, not real Edge focus or visibility changes.
  • The Postgres remote Workspace test (it needs a database) was not run in its CI form. The browser pass covered the same default-name path on Postgres.
  • An Entra member was not exercised. The member path used Auth0, and the owner used both providers.

🤖 Generated with Claude Code

@ultmaster

Copy link
Copy Markdown
Collaborator Author

Review of ebf1559b3c0e7276bf62d12d7a858ee0ed452b15

I reviewed all six commits and the 31-file diff against 0b4438c81f7fb5562dac8f96b19a80302c7f5d15. I recommend holding merge for the wrong-Workspace Chat retry and the failing storage check.

Findings

  • P1. Configure model can open a Chat in the wrong Disk Workspace. I reproduced the existing review thread in Chromium with local identity and two disposable Home folders that each contained a Space with the same ID. In Home A, open New conversation with no model or external agent. Use the application menu to switch to Home B and open its copy of the Space. The persistent toast is still present. Click Configure model and close Settings. Home B now has a Chat tab that was requested in Home A. The callback compares only the current Space ID. Capture the originating Workspace with the Space and check both before retry and after the async binding lookup. Retry callback · Existing thread
  • Merge blocker. The PostgreSQL contract suite has a stale default-name assertion. pnpm run test:storage-backends reproduced the Actions failure in a disposable PostgreSQL/Azurite run. The test expects ['Second', 'Workspace'] after creating a second Workspace. A fresh database correctly returns ['Default', 'Second']. The failure skips both storage-profile browser jobs. Assertion · Actions job
  • P2. The local SQLite rename editor has no entry point from the normal UI. On a fresh SQLite/Disk server with local Basic Auth, the API reports canManage: true, but Spaces shows a static “Home folder: Default” label and the application menu omits the switcher. Navigating directly to /setup exposes the pencil and the rename works. The local capability still requires the backend to materialize folders. If local SQL rename is supported, expose an entry point for callers who can manage the Workspace. The pathless chooser also presents an absolute-path field under “Home folder”. Server capability · Spaces link
  • P2. Composing Enter saves a partial Workspace name, and composing Escape discards the draft. In the local SQLite chooser, I dispatched Chromium keyboard events with isComposing: true while the name editor was active. Enter sent a successful PATCH with the partial name and closed the editor. Escape closed the editor and discarded the draft. Follow the composition guard in the shared inline title editor. Rename handler · Existing thread
  • P2. The route removal breaks old clients for references they used to open. I persisted a real local turn with a 74-character reference and upgraded the same SQLite deployment. The old path returned 200 on the base and 404 on the head. The query URL returned 200 on the head for both the 74-character reference and a stored 120-character reference. The long reference already failed on the base. Consider keeping the old path as an alias to the same validated handler if older clients or tabs must survive a rolling upgrade. History route

I also confirmed by inspection the two already-reported Bubble findings. The People browser spec still uses the removed en.people.access key, and the Workspace listing does a fresh principal and policy read per row through access.can instead of sharing the existing canMany snapshot. I did not run the Bubble browser test or measure query counts. People locator · Authorization fan-out

Verification

  • Built both snapshots with pnpm run build:web on Node 24.16.0 and pnpm 10.34.3. On the head, lint had zero errors. Format, typecheck, deployment scripts, i18n, Space Kits, and license headers passed. pnpm -r --if-present --no-bail run test passed 11,083 tests, with 29 skipped and 3 todo. The separate storage contract suite had 561 passed, 1 failed, and 1 skipped.
  • Chromium exercised free Disk/Disk, managed Disk/Disk, and SQLite/Disk with a local Basic Auth challenge. Verified no foreground identity recheck in local mode, both New conversation setup actions, Workspace switching and managed mode read-only behavior. Inspected the rendered rename controls and setup toast at 1440 × 900.
  • An in-place base-to-head upgrade of an isolated SQLite instance preserved the existing Workspace ID and name, its Space, and both conversations. A deterministic loopback OpenAI Responses fixture supplied model output through Huabu’s real runtime and HTTP history routes. Also verified that the new URL reads conversation detail after a full process restart.
  • I did not run packaged Electron, live model providers, live Auth0/Entra, physical OS IME input, or PostgreSQL/Azure browser acceptance. The PostgreSQL/Azurite result above is the storage contract suite.

The Postgres Workspace contract still expected a first Workspace named "Workspace" (the CI failure), and the People e2e spec located the switch by the removed people.access label.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t#435)

Space ids are scoped to a Workspace, so the setup toast's retry also checks the initiating Workspace, before retrying and after the binding loads, as createQuestionNodeAndCompose does. Otherwise a Workspace switch to a Space with the same id would create the Chat there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…icrosoft#435)

Enter and Escape that confirm or cancel a composition no longer save a partial name or close the editor, matching the inline title editors.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…microsoft#435)

Listing N Workspaces ran N separate authorization operations, each rereading the principal and building a fresh policy. The checks now go through access.canMany, falling back to per-resource can like readableSpaces.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 18:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the first-use and Workspace onboarding changes.

1 open issue
3 resolved since last review
1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants