Add support for custom build commands#2922
Open
sarsharma wants to merge 3 commits into
Open
Conversation
sarsharma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for specifying a custom build command(via CUSTOM_BUILD_COMMAND env var) in the generated build scripts for .NET Core, Python, and PHP platforms. This support already exists for nodejs platform. When a custom build command is provided, it overrides the default build steps (like
dotnet publish,composer install, orpip install) in the generated scripts. The implementation includes new configuration options, updates to script templates, and ensures the build process and file copying logic adapt accordingly.These changes make the build process more flexible and customizable for advanced scenarios.
Also introduced a new configuration key
SKIP_PLATFORM_DETECTIONand ensured the CLI correctly merges this setting from multiple sources. Follow up from #2918 to add parity to allow skip detection via env variable/cli flag.Testing
Deployed test apps for all platforms - nodejs, python, php, dotnet and set a CUSTOM_BUILD_COMMAND for each scenario and checked if the custom build command was used instead of oryx generated build commands. To verify this, the custom build command also writes a custom txt file which is served from
/for each app