[QuickAccent] Add en-dash to VK_MINUS for SPECIAL language#45965
Open
daverayment wants to merge 2 commits intomicrosoft:mainfrom
Open
[QuickAccent] Add en-dash to VK_MINUS for SPECIAL language#45965daverayment wants to merge 2 commits intomicrosoft:mainfrom
daverayment wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the en-dash character (U+2013, –) to the Quick Accent “Special Characters” mapping for the minus key so it’s available when users trigger Quick Accent on VK_MINUS, restoring expected behavior after prior character-set cleanup.
Changes:
- Add
–toLetterKey.VK_MINUSunder theSPECIALcharacter set (positioned before the em-dash). - Update the
VK_COMMAcomment to reflect intentional availability of–on both comma and minus keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Add en-dash to the existing dash characters available under the minus key for the Special Characters set.
PR Checklist
Detailed Description of the Pull Request / Additional comments
This PR adds the en-dash '–' character to the VK_MINUS key under the Special Characters character set, positioned before the em-dash character.
Although the character is available under VK_COMMA, it should be present under VK_MINUS, along with the other dash characters.
Previously, en-dash was available for VK_MINUS under the Hebrew language, so users who selected All available character sets (or who specifically selected Hebrew as a workaround) had access to en-dash via the minus key. However, this was seen as a duplication of the VK_COMMA functionality and the character was removed for the Hebrew character set in #43504. Although this is technically correct, this has understandably caused confusion for users who relied on the prior behaviour.
The comment on the VK_COMMA for the Special Characters declaration previously read:
// – is in VK_MINUS for other languages, but not VK_COMMA, so we add it here.That "for other languages" is telling. The Hebrew en-dash entry was removed, and the en-dash mapping for the minus key is not present for any other language, orphaning the functionality.
Validation Steps Performed
I built and ran the updated Quick Accent code and confirmed that the character was available when only the Special character set was selected, and that it was absent when that set was deselected. I confirmed that the character was available under both comma and minus keys.