Repository navigation
FIX: Accept only supported external inputs when building components #2959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
varunj-msft
wants to merge
10
commits into
microsoft:main
Choose a base branch
from
varunj-msft:varunj-msft/10765-Validate-Component-Parameters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+759
−69
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
133e4f1
FIX: Validate target and converter parameter types before construction
varunj-msft b33d822
Replace JSON type projection with an explicit registry input contract
varunj-msft 1a0f049
Merge remote-tracking branch 'origin/main' into varunj-msft/10765-Val…
varunj-msft c143188
Narrow registry validation to the supported external-input boundary
varunj-msft a84be3c
Merge origin/main
varunj-msft 3553736
Accept scalar collections and scalar alternatives, and check scenario…
varunj-msft 0628f57
Note that path scalars are external inputs and simplify two tests
varunj-msft ffacb80
Describe what the type catalogs return to external callers
varunj-msft 3ff7c74
Remove stale catalog route note from the GUI docs
varunj-msft 0c0c7f0
Let the preparation callback run before closing in the worker test
varunj-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The allowlist now accepts these inputs, but the catalog still describes their full Python annotations. The GUI therefore cannot configure several parameters that REST now accepts:
Collection[str]parameters serialize withis_list=False, so the converter form disables them.font_size: int | tuple[int, int]remains disabled by the converter form's union-type check.OpenAIVideoTarget.n_secondsis excluded by the target form's type check.Please make the external catalog describe the supported external form, while keeping the complete Python contract in internal registry metadata. Reuse the existing descriptors: supported flat collections should use the existing list representation, including element choices for enums. Mixed unions should expose the supported external alternatives, not require clients to interpret opaque Python alternatives.
Main already represents
list[SomeStringEnum]aslist[str]withis_list=Trueand enum-value choices. Please keep the new collection support consistent with that contract.Please also add coverage for serialized catalog metadata and the actual form submission path. The current creation tests send correctly typed values directly, so they cannot detect this mismatch. Check that the forms can supply
font_size=24,n_seconds=8, and SATA word lists with the correct JSON shapes.This should remain a small external-input projection, not recursive JSON conversion or component validation in the registry.