Repository navigation
DOC: Disable video autoplay - #3040
Merged
Roman Lutz (romanlutz) merged 3 commits intoOct 8, 2026
Merged
Roman Lutz (romanlutz) merged 3 commits into
Roman Lutz (romanlutz) merged 3 commits into
Conversation
Replace MP4 iframe embeds with linked preview images so walkthroughs open only after an explicit click. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use local iframe players with manual controls, pause hidden or competing walkthroughs, and publish their assets through MyST. Exclude embedded player pages from the version picker. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
hannahwestra25
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keep the Scanner and CoPyRIT walkthroughs embedded on the landing page, but require an explicit click on Play. The existing MP4 iframe URLs create browser-managed media documents that can autoplay both videos, including the video in the hidden tab.
playsinline, andpreload="none", without anautoplayattribute.static_filesconfiguration. Preserve the direct-video links and static-export placeholders.Related landing-page change: #2634. No PyRIT API or runtime behavior changes.
Tests and Documentation
Added regression tests for manual-playback defaults, published assets, sibling playback coordination, hidden-tab pausing, browser history restoration, and the version-picker opt-out. Updated the landing page and documented the static asset configuration and opt-out marker alongside their implementation.
Validation on the final code:
uv run --frozen --no-sync pytest -q tests\unit\build_scripts\test_landing_video_players.py tests\unit\build_scripts\test_inject_version_picker.py: passed, 18 tests.uv run --frozen --no-sync ruff check build_scripts\inject_version_picker.py tests\unit\build_scripts\test_landing_video_players.py tests\unit\build_scripts\test_inject_version_picker.py: passed.uv run --frozen --no-sync ruff format --check build_scripts\inject_version_picker.py tests\unit\build_scripts\test_landing_video_players.py tests\unit\build_scripts\test_inject_version_picker.py: passed.node --check doc\assets\videos\player.js: passed.doc,uv run --frozen --no-sync jupyter-book build --html --ci: passed.The original issue was reproduced on the published
/latest/landing page in automated headless Edge. Chrome and Firefox were not tested directly. The full unit suite and live-target integration tests were not run.JupyText was not run because no notebook or paired Python documentation files changed.