test(disk_usage): assert on error variants with matches!#804
Merged
Conversation
SensorLock
approved these changes
May 21, 2026
Replace .is_err() with matches!(_, Err(Error::Variant { .. })) in the
disk_usage tests and drop the module-level
#[expect(clippy::assertions_on_result_states)] override, restoring that
lint's coverage.
demoray
force-pushed
the
bcaswell/disk-usage-test-matches
branch
from
ffa27e2 to
d1726e3
Compare
SensorLock
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
.is_err()withmatches!(_, Err(Error::Variant { .. }))in thedisk_usagetests.Why:
Error::Other { context, .. }site still passes.is_err(). Thematches!check pins the variant (and, forf64_to_u64, thecontextstring).#[expect(clippy::assertions_on_result_states)]override, restoring that lint's coverage for the file.Verified locally:
cargo fmtcargo clippy --locked --all-targets --all-features -- -D warnings -D clippy::pedantic -A clippy::missing_errors_doccargo test --all-features(28 passed in the lib suite, 2 in convert)