fix(java): disable slowdebug variant for openjdk builds#17103
Merged
Conversation
reubeno
reviewed
May 9, 2026
Member
reubeno
left a comment
There was a problem hiding this comment.
Changes look good to me, when you're ready.
Collaborator
Author
|
I need to fix up the |
Contributor
There was a problem hiding this comment.
Pull request overview
Disables the slowdebug build variant for the Java 25 OpenJDK components in Azure Linux, and updates the published package manifests to match the resulting RPM outputs.
Changes:
- Set
build.without = ["slowdebug"]forjava-25-openjdkandjava-25-openjdk-portable. - Regenerate rendered specs to include the generated
*.azl.macrosfiles and load them during spec parsing. - Remove
*-slowdebugpackage entries frombase.packages.tomlandsdk.packages.toml, and refresh component lock fingerprints.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| specs/j/java-25-openjdk/java-25-openjdk.spec | Loads generated azldev macros and adds the macros file as Source9999; updates changelog. |
| specs/j/java-25-openjdk/java-25-openjdk.azl.macros | New generated macros file forcing --without slowdebug. |
| specs/j/java-25-openjdk-portable/java-25-openjdk-portable.spec | Loads generated azldev macros and adds the macros file as Source9999; updates changelog. |
| specs/j/java-25-openjdk-portable/java-25-openjdk-portable.azl.macros | New generated macros file forcing --without slowdebug. |
| locks/java-25-openjdk.lock | Updates input-fingerprint to reflect the component config change. |
| locks/java-25-openjdk-portable.lock | Updates input-fingerprint to reflect the component config change. |
| base/packages/sdk.packages.toml | Drops java-25-openjdk-portable*-slowdebug entries from the SDK package set. |
| base/packages/base.packages.toml | Drops java-25-openjdk*-slowdebug entries from the base package set. |
| base/comps/java-25-openjdk/java-25-openjdk.comp.toml | Disables slowdebug variant via build.without. |
| base/comps/java-25-openjdk-portable/java-25-openjdk-portable.comp.toml | Disables slowdebug variant via build.without. |
Comment on lines
+9
to
+11
| # All Azure Linux specs with overlays include this macro file, irrespective of whether new macros have been added. | ||
| %{load:%{_sourcedir}/java-25-openjdk.azl.macros} | ||
|
|
Comment on lines
+9
to
+11
| # All Azure Linux specs with overlays include this macro file, irrespective of whether new macros have been added. | ||
| %{load:%{_sourcedir}/java-25-openjdk-portable.azl.macros} | ||
|
|
f5fbec1 to
c9f8d07
Compare
reubeno
approved these changes
May 9, 2026
christopherco
commented
May 10, 2026
Add `build.without = ["slowdebug"]` to java-25-openjdk and java-25-openjdk-portable to skip building the -slowdebug subpackages.
Drop the corresponding *-slowdebug entries from base.packages.toml and sdk.packages.toml so the package lists stay consistent with what the build actually produces.
Introduce an `azl_release` build define and a spec-search-replace overlay that rewrites the `Release:` tag to `%[%{rpmrelease} + %{azl_release}]`. This keeps the Fedora-style single-number Release schema while letting us bump independently of upstream. Set `azl_release` to 2 for both java-25-openjdk and java-25-openjdk-portable so the effective Release stays at 6 and 3 respectively.
Bump the java-25-openjdk upstream pin to 5443056bc5b97bcc78e36144b6a28b8937dc6cee, which corrects upstreams `%global rpmrelease` from 3 to 4.
c9f8d07 to
930c75c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
build.without = ["slowdebug"]to java-25-openjdk and java-25-openjdk-portable to skip building the -slowdebug subpackages.Drop the corresponding *-slowdebug entries from base.packages.toml and sdk.packages.toml so the package lists stay consistent with what the build actually produces.
Fixes: AB#19862