[RFC] fix(ghc-srpm-macros): disable Haskell profiling libraries#17105
Draft
christopherco wants to merge 1 commit intotomls/base/mainfrom
Draft
[RFC] fix(ghc-srpm-macros): disable Haskell profiling libraries#17105christopherco wants to merge 1 commit intotomls/base/mainfrom
christopherco wants to merge 1 commit intotomls/base/mainfrom
Conversation
Azure Linux does not ship any ghc-*-prof RPMs. Building them roughly
doubles the build time of every Haskell package and produces ~290
unused subpackages across the ecosystem.
Flip the `with_ghc_prof` defaults in macros.ghc-srpm so all ghc-*
SRPMs (ghc itself plus the cabal-rpm generated downstream specs that
gate `%files prof` on `%if %{with ghc_prof}`) skip building their
profiling subpackages by default.
Also drop the corresponding ghc-*-prof entries (and the ghc-prof
metapackage) from sdk.packages.toml so the SDK package list reflects
what actually ships.
Verified: ghc-srpm-macros builds; in a mock chroot with the new RPM
installed, `rpm --eval '%{?with_ghc_prof}'` returns `0`.
christopherco
changed the title
christopherco
changed the title
Member
|
Change looks pretty good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure Linux does not ship any ghc-*-prof RPMs. Building them roughly doubles the build time of every Haskell package and produces ~290 unused subpackages across the ecosystem.
Flip the
with_ghc_profdefaults in macros.ghc-srpm so all ghc-* SRPMs (ghc itself plus the cabal-rpm generated downstream specs that gate%files profon%if %{with ghc_prof}) skip building their profiling subpackages by default.Also drop the corresponding ghc-*-prof entries (and the ghc-prof metapackage) from sdk.packages.toml so the SDK package list reflects what actually ships.
Verified: ghc-srpm-macros builds; in a mock chroot with the new RPM installed,
rpm --eval '%{?with_ghc_prof}'returns0.