fix(fast-html): add errors fixture for f-template error cases#7406
Draft
fix(fast-html): add errors fixture for f-template error cases#7406
Conversation
Add a test fixture that covers the two error conditions thrown by the f-template element: no template element present and multiple template elements present. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds an
errorstest fixture for@microsoft/fast-htmlthat covers the two error conditions thrown by the<f-template>element:<f-template>contains no<template>child, anoTemplateProvidederror (code 2000) is thrown.<f-template>contains more than one<template>child, amoreThanOneTemplateProvidederror (code 2001) is thrown.The fixture includes
index.html,main.ts, anderrors.spec.ts. Tests usepage.addInitScriptto interceptunhandledrejectionevents (the errors originate inside an unhandled promise chain) for reliable cross-browser coverage across Chromium, Firefox, and WebKit.📑 Test Plan
Run the new fixture tests:
All 6 tests pass (2 cases × 3 browsers).
✅ Checklist
General
$ npm run change