Reuse SMART search integration fixture#5588
Open
mikaelweave wants to merge 7 commits into
Open
Conversation
Log SMART integration fixture setup, resource upsert, and search-service timings so the PR pipeline can identify whether the slow SmartSearch shard is dominated by setup or specific query patterns. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Seed SMART integration data once per version and data store so SmartOnFhir tests avoid rebuilding the expensive storage fixture for every test method. Use unique IDs for mutation tests while preserving update semantics, and dispose cached fixtures when the test process exits. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5588 +/- ##
=======================================
Coverage 77.33% 77.34%
=======================================
Files 996 996
Lines 36534 36539 +5
Branches 5538 5539 +1
=======================================
+ Hits 28255 28260 +5
+ Misses 6912 6908 -4
- Partials 1367 1371 +4 🚀 New features to boost your workflow:
|
Remove process-lifetime fixture caching and diagnostic timing wrappers while keeping shared SMART test data setup under xUnit fixture lifetime. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mikaelweave
commented
May 27, 2026
mikaelweave
commented
May 27, 2026
Move test setup out of the no-op async lifecycle and inline the one-line upsert wrapper. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…portunity' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
feordin
reviewed
May 28, 2026
| Assert.DoesNotContain(results.Results, r => r.Resource.ResourceTypeName == "Practitioner"); | ||
| } | ||
|
|
||
| public sealed class SmartSearchSharedFixture : IAsyncLifetime |
Contributor
There was a problem hiding this comment.
It seems like we usually put fixtures in their own file, rather than with the test cases. This is a suggestion, just to match the rest of the code base.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…o use Where' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
test\Microsoft.Health.Fhir.Shared.Tests.Integration\Features\Smart\SmartSearchTests.cs.git diff --checkandgit diff --check origin/main...HEADpassed.dotnet build test\Microsoft.Health.Fhir.R4.Tests.Integration\Microsoft.Health.Fhir.R4.Tests.Integration.csproj -f net9.0passed (Build succeeded in 149.5s).