Skip to content

[Draft] [Experiment] - Optimize PR AAD setup reuse#5591

Draft
mikaelweave wants to merge 1 commit into
mainfrom
mikaelweave/aad-setup-optimization
Draft

[Draft] [Experiment] - Optimize PR AAD setup reuse#5591
mikaelweave wants to merge 1 commit into
mainfrom
mikaelweave/aad-setup-optimization

Conversation

@mikaelweave
Copy link
Copy Markdown
Contributor

Summary

  • Remove current PR AAD deletion from the PR setup hot path while keeping explicit cleanup flows intact.
  • Add timing around AAD setup pipeline and script sub-steps, and skip module installs when modules are already available.
  • Preserve AAD user/client secrets when existing Key Vault secrets match desired state, including client credential key-id validation.

Validation

  • PowerShell parser checks for FhirServerRelease and FhirServer scripts
  • AAD setup inline script parser check
  • git diff --check
  • Static assertions for cleanup removal, timing/module helpers, and desired-state secret handling

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mikaelweave mikaelweave changed the title Optimize PR AAD setup reuse [Draft] Optimize PR AAD setup reuse May 28, 2026
@mikaelweave mikaelweave changed the title [Draft] Optimize PR AAD setup reuse [Draft] [Experiment] - Optimize PR AAD setup reuse May 28, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.33%. Comparing base (ee554e9) to head (ccfb076).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5591      +/-   ##
==========================================
- Coverage   77.33%   77.33%   -0.01%     
==========================================
  Files         996      996              
  Lines       36534    36534              
  Branches     5538     5538              
==========================================
- Hits        28255    28253       -2     
- Misses       6912     6913       +1     
- Partials     1367     1368       +1     

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants