Bug fix for leaked LCOW resources; expand logs#2655
Open
helsaawy wants to merge 1 commit intomicrosoft:mainfrom
Open
Bug fix for leaked LCOW resources; expand logs#2655helsaawy wants to merge 1 commit intomicrosoft:mainfrom
helsaawy wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Incorrect resource closures did not cause errors in non-virtual pod scenarios since the uVM was closed after sandbox exit, so leaked resources where released then. Fix bug where LCOW adapter removal incorrectly used the endpoint ID as the namespace ID. Don't attempt to remove virtual pod endpoints before host removes adapters from host. Unmount and delete virtual pod directories and mounts. Add more logs to networking and resource code paths to help debug leaked vPCI endpoint devices. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorrect resource closures did not cause errors in non-virtual pod scenarios since the uVM was closed after sandbox exit, so leaked resources where released then.
Fix bug where LCOW adapter removal incorrectly used the endpoint ID as the namespace ID.
Don't attempt to remove virtual pod endpoints before host removes adapters from host.
Unmount and delete virtual pod directories and mounts.
Add more logs to networking and resource code paths to help debug leaked vPCI endpoint devices and other issues.