Repository navigation
Fix ProcessContainer environment block sort lint - #1387
Merged
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change preserves existing behavior and is adequately tested.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes the ProcessContainer Clippy lint while preserving stable, case-insensitive environment-variable ordering.
Changes:
- Replaces the redundant comparator with
sort_by_key. - Adds regression coverage for case-equivalent keys.
| File | Description |
|---|---|
src/backends/process_container/common/src/appcontainer_runner.rs |
Updates environment sorting and adds regression coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This PR replaces the redundant environment-block sort comparator with sort_by_key while preserving case-insensitive key ordering and stable handling of equal keys. Details * Use sort_by_key for the existing uppercase environment-variable key. * Test that keys differing only by case retain their original order. Tests * cargo fmt --manifest-path .\src\Cargo.toml --all -- --check: passed. * cargo test --manifest-path .\src\Cargo.toml -p process_container_common --quiet: passed (318 tests; 1 ignored). * cargo clippy --manifest-path .\src\Cargo.toml --workspace --all-targets -- -D warnings: passed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ff6d3538-5272-492f-aba0-5f7ef9feda2f Generated-with: gpt-6-sol
Gudge (MGudgin)
force-pushed
the
user/gudge/fix-env-block-sort-clippy
branch
from
October 7, 2026 15:40
90905ac to
602238b
Compare
Branden Bonaby (bbonaby)
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the workspace Clippy lint in ProcessContainer environment-block
serialization. It replaces the redundant comparator with
sort_by_keywhilepreserving stable, case-insensitive key ordering.
Details
Tests
cargo fmt --manifest-path .\src\Cargo.toml --all -- --check— passed.cargo test --manifest-path .\src\Cargo.toml -p process_container_common --quiet— passed (318 tests; 1 ignored).cargo clippy --manifest-path .\src\Cargo.toml --workspace --all-targets -- -D warnings— passed.Microsoft Reviewers: Open in CodeFlow