Skip to content

crypto: Add symcrypt backends for aes-kwp and xts-aes#3553

Open
smalis-msft wants to merge 1 commit into
microsoft:mainfrom
smalis-msft:crypto-sc-more
Open

crypto: Add symcrypt backends for aes-kwp and xts-aes#3553
smalis-msft wants to merge 1 commit into
microsoft:mainfrom
smalis-msft:crypto-sc-more

Conversation

@smalis-msft
Copy link
Copy Markdown
Contributor

I think these are the final two?

@smalis-msft smalis-msft requested a review from a team as a code owner May 21, 2026 23:49
Copilot AI review requested due to automatic review settings May 21, 2026 23:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds SymCrypt implementations for the remaining crypto primitives that previously lacked SymCrypt coverage, aligning the crypto support crate’s backend matrix across OpenSSL / Windows-native / SymCrypt.

Changes:

  • Add a SymCrypt backend for XTS-AES-256.
  • Add a SymCrypt backend for AES-KWP (RFC 5649).
  • Update backend selection wiring and bump the pinned rust-symcrypt git revision in Cargo.lock.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
support/crypto/src/xts_aes_256/symcrypt.rs Implements XTS-AES-256 encrypt/decrypt using symcrypt::cipher::xts::XtsAesKey.
support/crypto/src/xts_aes_256/mod.rs Enables symcrypt as a supported backend and wires sys to the SymCrypt implementation under cfg(symcrypt).
support/crypto/src/aes_kwp/symcrypt.rs Implements AES-KWP wrap/unwrap using symcrypt::cipher::aes_kw::AesKwpKey, including key-size validation.
support/crypto/src/aes_kwp/mod.rs Enables symcrypt as a supported backend and wires sys to the SymCrypt implementation under cfg(symcrypt).
Cargo.lock Updates the pinned git commit for symcrypt / symcrypt-sys to pick up needed APIs.

@smalis-msft smalis-msft enabled auto-merge (squash) May 22, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants