Repository navigation
fix: validate live PR title on workflow reruns - #234
Merged
Merged
Conversation
Resolve the current pull request title through the GitHub API so rerunning an older workflow after a title correction does not reuse stale event data. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
martin-kolinek
commented
Oct 7, 2026
martin-kolinek
commented
Oct 7, 2026
martin-kolinek
commented
Oct 7, 2026
Martin Taillefer (geeknoid)
approved these changes
Oct 7, 2026
martin-kolinek
commented
Oct 7, 2026
Preserve the live PR title lookup while adding bounded API retries, documenting its permission requirement, and syncing the generated catalog with current main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
=====================================
Coverage 98.9% 98.9%
=====================================
Files 304 304
Lines 44436 44436
=====================================
Hits 43975 43975
Misses 461 461
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change preserves merge-group behavior, fails closed on lookup errors, and includes consistent tests, documentation, and generated updates.
0 open findings
What changed in this PR
Fixes stale PR-title validation on workflow reruns by fetching the current title before each pr-fast matrix leg.
Changes:
- Adds a retried GitHub API lookup that fails closed and skips merge-group runs.
- Adds regression assertions and updates generated workflows, snapshots, and checksums.
- Documents live-title resolution and permission requirements.
| File | Description |
|---|---|
justfiles/anvil/checks/pr-title.just |
Updates explanatory comments. |
crates/cargo-anvil/tests/snapshots/snapshots__local_only.snap |
Refreshes recipe-comment snapshot. |
crates/cargo-anvil/tests/snapshots/snapshots__github_backend.snap |
Captures lookup and comment changes. |
crates/cargo-anvil/tests/snapshots/snapshots__ado_backend.snap |
Refreshes recipe-comment snapshot. |
crates/cargo-anvil/templates/justfiles/anvil/checks/pr-title.just |
Documents API-based title resolution. |
crates/cargo-anvil/templates/github/pr-impl-workflow.yml |
Adds live-title lookup and output wiring. |
crates/cargo-anvil/src/anvil/artifacts/github.rs |
Adds workflow regression assertions. |
crates/cargo-anvil/docs/design/github.md |
Documents lookup behavior and permissions. |
crates/cargo-anvil/docs/design/checks.md |
Updates the title-check contract. |
.github/workflows/anvil-pr-impl.yml |
Applies the generated workflow change. |
.anvil.lock |
Refreshes generated-artifact checksums. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Evgenii (Vaiz)
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Resolves the current pull request title through the GitHub API immediately before each
pr-fastmatrix leg runs.Workflow reruns retain the original
pull_requestevent payload, so a corrected title previously continued to fail when an older run was retried. The event payload now supplies only the stable PR number; title validation uses the current API value. Merge-group behavior remains unchanged, and lookup failures fail closed.Validation
cargo test --quiet -p cargo-anvil --lib anvil::artifacts::githubcargo test --quiet -p cargo-anvil --test schemascargo test --quiet -p cargo-anvil --test snapshotscargo run --quiet -p cargo-anvil -- anvil --dry-runjust anvil-fmt --fix