Skip to content

chore: untangle global version of ohno #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
martintmk wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: untangle global version of ohno #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/templated_uri/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ uuid = ["dep:uuid"]
[dependencies]
data_privacy.workspace = true
http.workspace = true
ohno.workspace = true
ohno = "0.3.1"
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohno = "0.3.1" is a caret requirement (equivalent to ^0.3.1), so it will still allow newer 0.3.x releases. If the goal is to keep the version fixed to avoid cascading bumps, use an exact requirement (e.g. =0.3.1) instead.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This switches templated_uri to registry ohno (0.3.1) while the workspace still provides a path ohno crate (0.3.2), which creates two ohno versions in the workspace lockfile and can cause confusing duplicate types/traits across crate boundaries. Consider adding a workspace-level [patch.crates-io] ohno = { path = "crates/ohno" } for local development while keeping the published dependency pinned, and ensure templated_uri is released with a new patch version so crates.io consumers can pick up the change.

Copilot uses AI. Check for mistakes.
pct-str = { workspace = true, features = ["std"] }
serde = { workspace = true, features = ["std", "derive"], optional = true }
templated_uri_macros.workspace = true
Expand Down
Loading