fix(fabric): Add back compat layer for validKeysDown and validKeysUp#2879
Open
Saadnajmi wants to merge 4 commits intomicrosoft:mainfrom
Open
fix(fabric): Add back compat layer for validKeysDown and validKeysUp#2879Saadnajmi wants to merge 4 commits intomicrosoft:mainfrom
validKeysDown and validKeysUp#2879Saadnajmi wants to merge 4 commits intomicrosoft:mainfrom
Conversation
|
Saadnajmi
force-pushed
the
copilot/validkeys-js-compat-minimal
branch
from
9d2170e to
8802415
Compare
acoates-ms
approved these changes
Mar 31, 2026
vmoroz
approved these changes
Mar 31, 2026
dannyvv
approved these changes
Mar 31, 2026
- Keep existing _onKeyDown/_onKeyUp handlers from main, just read from effectiveProps instead of props - Fix Flow errors: restore let actualView, use Array instead of $ReadOnlyArray in LegacyKeyResult type - Zero deleted lines from upstream — purely additive changes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We still have some client bundles downstream that refer to this prop. Add back some compatibility without adding it to the types
Test Plan:
CI should pass