Fix AppendCommandLine missing from NewTerminalArgs serialization#19917
Closed
TheJesper wants to merge 1 commit intomicrosoft:mainfrom
Closed
Fix AppendCommandLine missing from NewTerminalArgs serialization#19917TheJesper wants to merge 1 commit intomicrosoft:mainfrom
TheJesper wants to merge 1 commit intomicrosoft:mainfrom
Conversation
microsoft-github-policy-service
Bot
added
the
Issue-Question
AppendCommandLine was defined as a property on NewTerminalArgs but was not included in FromJson, ToJson, Copy, or Hash. This meant the property was silently dropped during any serialization round-trip (e.g. tab duplication, window restore, settings persistence). Adds AppendCommandLine to all four methods, consistent with every other property on NewTerminalArgs. Fixes microsoft#14270
TheJesper
force-pushed
the
fix/append-commandline-serialization
branch
from
57b2736 to
635c5ed
Compare
carlos-zamora
requested changes
Mar 13, 2026
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
A few notes:
- The PR says it fixes #14270. However, that issue is already closed. It seems like the fix there was to configure shell integration (see this comment). In fact, that issue has been closed since 2022.
AppendCommandlineis used by the--appendCommandlineCLI flag added in #15822. Looks like it was specifically designed for wt.exe, so I'm not sure if there's really any value to expose it beyond that.
With all that said, I'm requesting changes and closing this PR. Let me know if you disagree and we can move forward from there.
microsoft-github-policy-service
Bot
added
the
Needs-Author-Feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppendCommandLinewas defined as a property onNewTerminalArgsbut omitted fromFromJson,ToJson,Copy, andHashAppendCommandLineto all four methods, consistent with every other property onNewTerminalArgsDetails
Every other property on
NewTerminalArgs(Commandline,StartingDirectory,TabTitle,ProfileIndex,Profile,SessionId,TabColor,SuppressApplicationTitle,ColorScheme,Elevate,ReloadEnvironmentVariables,ContentId) is present in all four serialization methods.AppendCommandLinewas the only one missing.Validation
SettingsModel.Unit.Tests.dll— all tests passNewTerminalArgspropertiesFixes #14270