[WIP] Rewrite paste and drag/drop broadcasting#20165
Conversation
| co_return; | ||
| } | ||
|
|
||
| // TODO(DH) the fuckin' delimiter from DragDropDelimiter |
| return profileMenuItemFlyout; | ||
| } | ||
|
|
||
| static void _translatePathInPlace(std::wstring& fullPath, PathTranslationStyle translationStyle) |
There was a problem hiding this comment.
Move this to a helper somewhere, not into the nearly 9000-line TerminalPage
This comment has been minimized.
This comment has been minimized.
| SetForegroundWindow(*_hostingHwnd); | ||
| } | ||
|
|
||
| if (e.DataView().Contains(StandardDataFormats::ApplicationLink())) |
There was a problem hiding this comment.
per an internal PR on another feature, just like the clipboard, ENUMERATE the formats and then pick the first one we support. It lets the source app order them in its preferred manner
| } | ||
|
|
||
| // TODO(DH) the fuckin' delimiter from DragDropDelimiter | ||
| std::unordered_map<PathTranslationStyle, winrt::hstring> translatedPaths; |
There was a problem hiding this comment.
the cache is too over-engineered anyway. just eat the cost of enumerating the list of filenames more than once.
| return _control.CharacterDimensions(); | ||
| } | ||
|
|
||
| TerminalApp::TerminalPaneContent TerminalPaneContent::ContentFromControl(const winrt::Microsoft::Terminal::Control::TermControl& control) |
There was a problem hiding this comment.
okay the REAL reason that we need to use TerminalPaneContent instead of TermControl as the broadcast medium is that TPC knows the Profile (app layer) and Control doesn't (control layer)
There was a problem hiding this comment.
the two ways I've figured out how to go from Control to Profile are:
- this weak mapping you see here
- enumerate every pane to find the pane whose content's control is the current control (which sounds frankly stupid)
if you have a better way to do this than either of those... plz holler
in my asciicast work, i needed to associate a third thing with each control: the Recorder instance.
4ebafba to
f42146f
Compare
This comment has been minimized.
This comment has been minimized.
f42146f to
b9e56de
Compare
This comment has been minimized.
This comment has been minimized.
Add the broadcast group helpers Port paste to the broadcast helpers
b9e56de to
17cdf29
Compare
@check-spelling-bot Report
|
| Dictionary | Entries | Covers | Uniquely |
|---|---|---|---|
| cspell:csharp/csharp.txt | 32 | 2 | 2 |
| cspell:aws/aws.txt | 232 | 2 | 2 |
| cspell:fonts/fonts.txt | 536 | 1 | 1 |
Consider adding to the extra_dictionaries array (in the .github/actions/spelling/config.json file):
"cspell:csharp/csharp.txt",
"cspell:aws/aws.txt",
"cspell:fonts/fonts.txt",
To stop checking additional dictionaries, put (in the .github/actions/spelling/config.json file):
"check_extra_dictionaries": []Warnings ⚠️ (1)
See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.
| Count | |
|---|---|
| 54 |
See
✏️ Contributor please read this
By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.
If the listed items are:
- ... misspelled, then please correct them instead of using the command.
- ... names, please add them to
.github/actions/spelling/allow/names.txt. - ... APIs, you can add them to a file in
.github/actions/spelling/allow/. - ... just things you're using, please add them to an appropriate file in
.github/actions/spelling/expect/. - ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in
.github/actions/spelling/patterns/.
See the README.md in each directory for more information.
🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉
If the flagged items are 🤯 false positives
If items relate to a ...
-
binary file (or some other file you wouldn't want to check at all).
Please add a file path to the
excludes.txtfile matching the containing file.File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
^refers to the file's path from the root of the repository, so^README\.md$would exclude README.md (on whichever branch you're using). -
well-formed pattern.
If you can write a pattern that would match it,
try adding it to thepatterns.txtfile.Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.
Note that patterns can't match multiline strings.
Targets #20155.
I'm opening this to leave some notes.