Introduce Profiles page to SUI#20199
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| auto subPage = crumb->SubPage(); | ||
| for (const auto& item : _menuItemSource) | ||
| // Find the new profile VM by guid | ||
| if (const auto newProfileVM = _FindProfileVMByGuid(profileTag.OriginalProfileGuid())) |
| } | ||
| else if (*clickedItemTag == colorSchemesTag) | ||
| { | ||
| // Color Schemes page is a accessible from root level and within Profiles, |
| // Suppress the handler to avoid double-navigation | ||
| _colorSchemesPageViewModelChangedRevoker.revoke(); | ||
|
|
||
| // Color Schemes page is a accessible from within Profiles and root level, |
| void MainPage::_NavigateToProfileHandler(const IInspectable& /*sender*/, winrt::guid profileGuid) | ||
| { | ||
| if (const auto profileNavItem = _FindProfileNavItem(profileGuid)) | ||
| if (const auto profileVM = _FindProfileVMByGuid(profileGuid)) |
| } | ||
|
|
||
| MUX::Controls::NavigationViewItem MainPage::_FindProfileNavItem(winrt::guid profileGuid) const | ||
| Editor::ProfileViewModel MainPage::_FindProfileVMByGuid(winrt::guid profileGuid) const |
| void _NavigateToProfileHandler(const IInspectable& sender, winrt::guid profileGuid); | ||
| void _NavigateToColorSchemeHandler(const IInspectable& sender, const IInspectable& args); | ||
| Microsoft::UI::Xaml::Controls::NavigationViewItem _FindProfileNavItem(winrt::guid profileGuid) const; | ||
| Editor::ProfileViewModel _FindProfileVMByGuid(winrt::guid profileGuid) const; |
Demo
|
@check-spelling-bot Report
|
| Dictionary | Entries | Covers | Uniquely |
|---|---|---|---|
| cspell:csharp/csharp.txt | 32 | 2 | 2 |
| cspell:aws/aws.txt | 232 | 2 | 2 |
| cspell:fonts/fonts.txt | 536 | 1 | 1 |
Consider adding to the extra_dictionaries array (in the .github/actions/spelling/config.json file):
"cspell:csharp/csharp.txt",
"cspell:aws/aws.txt",
"cspell:fonts/fonts.txt",
To stop checking additional dictionaries, put (in the .github/actions/spelling/config.json file):
"check_extra_dictionaries": []Forbidden patterns 🙅 (1)
In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.
These forbidden patterns matched content:
Should be an
(?<=\s)a(?= (?:a(?!nd\s|s\s)|e(?!u)|i(?![ns]\s)|o(?!f\b|nc?e)|u(?!\d|biquitous|int|kr|n[ai]|r[ael]|s[aeiu]|short|tf\d*|t_|til|topia|uid|vula|v\b)|y(?!aml|arn|e|ie|oga|oung|y)))
Errors and Warnings ❌ (2)
See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.
| ❌ Errors and Warnings | Count |
|---|---|
| 54 | |
| ❌ forbidden-pattern | 2 |
See ❌ Event descriptions for more information.
✏️ Contributor please read this
By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.
If the listed items are:
- ... misspelled, then please correct them instead of using the command.
- ... names, please add them to
.github/actions/spelling/allow/names.txt. - ... APIs, you can add them to a file in
.github/actions/spelling/allow/. - ... just things you're using, please add them to an appropriate file in
.github/actions/spelling/expect/. - ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in
.github/actions/spelling/patterns/.
See the README.md in each directory for more information.
🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉
If the flagged items are 🤯 false positives
If items relate to a ...
-
binary file (or some other file you wouldn't want to check at all).
Please add a file path to the
excludes.txtfile matching the containing file.File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
^refers to the file's path from the root of the repository, so^README\.md$would exclude README.md (on whichever branch you're using). -
well-formed pattern.
If you can write a pattern that would match it,
try adding it to thepatterns.txtfile.Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.
Note that patterns can't match multiline strings.
2 participants
Summary of the Pull Request
Updates the settings UI to introduce a new Profiles page. This page includes:
Validation Steps Performed
Scenarios:
PR Checklist
Related to #17000