Skip to content

Occasionally call didOpen with different contents.#218

Open
DanielRosenwasser wants to merge 2 commits intomainfrom
didOpenWithDifferentContents
Open

Occasionally call didOpen with different contents.#218
DanielRosenwasser wants to merge 2 commits intomainfrom
didOpenWithDifferentContents

Conversation

@DanielRosenwasser
Copy link
Copy Markdown
Member

See microsoft/typescript-go#3483 for how we fixed a problem around clients calling didOpen with different file contents.

DanielRosenwasser and others added 2 commits April 22, 2026 01:58
@jakebailey
Copy link
Copy Markdown
Member

I feel like might be too destructive, given this can effectively hide the real contents for later requests?

@gabritto
Copy link
Copy Markdown
Member

I feel like might be too destructive, given this can effectively hide the real contents for later requests?

Do you have an example in mind?

@jakebailey
Copy link
Copy Markdown
Member

I don't have a specific example, I just mean that if we clear out the contents, yes, we are testing what happens when you clear out the contents, but then we're spending more time doing hopefully "nothing" instead of testing the other features.

Maybe this happens rarely enough to not matter?

@gabritto
Copy link
Copy Markdown
Member

I don't have a specific example, I just mean that if we clear out the contents, yes, we are testing what happens when you clear out the contents, but then we're spending more time doing hopefully "nothing" instead of testing the other features.

Maybe this happens rarely enough to not matter?

I thought 0.000625 was a small enough number to avoid getting too much in the way of the other requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants