Validate repository connection before disconnect operation

[Copilot]

The "Disconnect from Repo..." command executes successfully on apps with deployment source already set to "None", showing confusing dialogs with empty repository names and performing no-op updates.

Changes

• Added pre-flight validation in disconnectRepo command to check scmType before proceeding
• Throw user-friendly error when scmType === ScmType.None: "This app is not connected to any repository."

// Check if the app is already disconnected from any repository
const client = await node.parent.site.createClient(context);
const siteConfig = await client.getSiteConfig();

if (siteConfig.scmType === ScmType.None) {
    throw new Error(localize('notConnectedToRepo', 'This app is not connected to any repository.'));
}

This prevents the confusing Disconnect from "{0}"? dialog where {0} is empty, and avoids unnecessary API calls to set deployment source to "None" when already "None".

Original prompt

---

This section details on the original issue you should resolve

<issue_title>“Disconnect from Repo...” is shown even when the deployment source is set to “None”</issue_title>
<issue_description>OS: Win 11
Build Version: 20260106.1

Repro Steps:

1. Create a new web app in VS Code.
2. Expand this web app -> Right click "Deployments" node to open its context menu.
3. Check whether there is no "Disconnect from Repo..." action for "Deployments" node.

Expect:
There is no "Disconnect from Repo..." action for "Deployments" node.

Actual:
Extra "Disconnect from Repo..." action appears for "Deployments" node.

More Info:
Execute "Disconnect from Repo..." action for the above web app -> Observe confirmation dialog shows Disconnect from "{0}"? -> Click "Disconnect" button -> Observe notification: Deployment source for "" has been updated to "None".
</issue_description>

<agent_instructions>Throw a user friendly error that their app is not connected to any repository.

PLEASE DO NOT CHANGE THE MAIN.JS FILE</agent_instructions>

Comments on the Issue (you are @copilot in this section)

• Fixes “Disconnect from Repo...” is shown even when the deployment source is set to “None” #2798

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[alexweininger]

Addressed the feedback — now using UserCancelledError with a warning toast via window.showWarningMessage. This gracefully cancels the operation, suppresses the Report Issue button, and shows the user an informative warning message.

Changes in ef9424a:

• Replaced throw new Error(...) → throw new UserCancelledError('notConnectedToRepo')
• Added void window.showWarningMessage(...) to show a warning toast before cancelling

[Copilot]

Pull request overview

Updates the “Disconnect from Repo…” command flow to avoid running a disconnect operation (and showing confusing empty repo-name dialogs) when the app’s deployment source is already set to “None”.

Changes:

• Adds a pre-flight scmType check before calling the underlying disconnect operation.
• Introduces a localized “not connected” user-facing message for the no-op/disconnected case.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

The PR description says this scenario should throw a user-friendly error (e.g., Error(localize(...))), but the implementation shows a warning toast and then throws UserCancelledError. Treating this as a cancellation may suppress normal error handling/telemetry and doesn’t match the intended behavior/message contract. Consider throwing an Error with the localized message (and avoid the extra warning toast) so the user sees a clear error and the command stops consistently.

[Copilot]

This command has an IActionContext available; elsewhere in the repo user prompts typically use context.ui.showWarningMessage(...) (e.g., src/commands/logstream/enableFileLogging.ts and src/commands/appSettings/getLocalEnvironmentVariables.ts). Using vscode.window here is inconsistent with that pattern and makes it harder to attach modal/step metadata consistently. Consider switching to context.ui.showWarningMessage (or removing the prompt entirely if you throw a user-facing Error) so you can also drop the window import.