Skip to content

Replace state provider with zustand.#21484

Closed
aasimkhan30 wants to merge 3 commits intomainfrom
aasim/feat/zustand
Closed

Replace state provider with zustand.#21484
aasimkhan30 wants to merge 3 commits intomainfrom
aasim/feat/zustand

Conversation

@aasimkhan30
Copy link
Copy Markdown
Contributor

Description

Replacing state provider with zustand to see if it solves some state update misses.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2026

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 6408 KB 6409 KB ⚪ 1 KB ( 0% )
sql-database-projects VSIX 7061 KB 7061 KB ⚪ 0 KB ( 0% )
data-workspace VSIX 535 KB 535 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 33.87097% with 82 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.70%. Comparing base (64e8b10) to head (135039a).

Files with missing lines Patch % Lines
...ql/src/reactviews/common/vscodeWebviewProvider.tsx 30.97% 78 Missing ⚠️
...s/mssql/src/reactviews/common/useVscodeSelector.ts 50.00% 2 Missing ⚠️
...ews/pages/SchemaDesigner/schemaDesignerSelector.ts 0.00% 1 Missing ⚠️
...ges/SchemaDesigner/schemaDesignerStateProvider.tsx 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (33.87%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #21484   +/-   ##
=======================================
  Coverage   72.69%   72.70%           
=======================================
  Files         330      330           
  Lines       98395    98397    +2     
  Branches     5455     5455           
=======================================
+ Hits        71529    71538    +9     
+ Misses      26866    26859    -7     
Files with missing lines Coverage Δ
...ctviews/pages/ExecutionPlan/executionPlanGraph.tsx 80.23% <100.00%> (ø)
...pages/ExecutionPlan/executionPlanStateProvider.tsx 77.77% <100.00%> (ø)
...ql/src/reactviews/pages/ExecutionPlan/iconMenu.tsx 91.02% <100.00%> (ø)
.../src/reactviews/pages/ExecutionPlan/properties.tsx 91.94% <100.00%> (ø)
extensions/mssql/src/sharedInterfaces/form.ts 100.00% <100.00%> (ø)
...ews/pages/SchemaDesigner/schemaDesignerSelector.ts 57.14% <0.00%> (+12.69%) ⬆️
...ges/SchemaDesigner/schemaDesignerStateProvider.tsx 16.60% <0.00%> (+0.08%) ⬆️
...s/mssql/src/reactviews/common/useVscodeSelector.ts 66.66% <50.00%> (+35.71%) ⬆️
...ql/src/reactviews/common/vscodeWebviewProvider.tsx 34.90% <30.97%> (-0.63%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Aasim Khan added 2 commits March 8, 2026 23:04
- Removed unnecessary type parameters from useVscodeWebview and related selectors in Object Management, Profiler, Publish Project, Query Result, Schema Compare, Schema Designer, Table Designer, Table Explorer, and User Survey components.
- Updated imports to use useWebviewStore for accessing theme and key bindings instead of useVscodeWebview where applicable.
- Cleaned up code by eliminating unused types and improving readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants