Query Profiler - Fix on Launching from a standard on prem - with default DB#21610
Merged
allancascante merged 1 commit intomainfrom Mar 13, 2026
Merged
Conversation
…n the connection profile
allancascante
requested review from
Benjin,
aasimkhan30,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez,
manujoseph85 and
ssreerama
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Query Profiler launch for on-prem connections that have a default (user) database set in the connection profile, which previously caused the profiler UI to not reflect the created session’s state/events.
Changes:
- Clear
connectionProfile.databasefor on-prem profiler launches (while preserving it as an initial UI database filter when applicable). - Add unit tests validating the on-prem behavior for user vs system databases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extensions/mssql/src/profiler/profilerController.ts | Clears database on on-prem launches to ensure server-scoped XEvent session discovery works correctly. |
| extensions/mssql/test/unit/profiler/profilerController.test.ts | Adds regression tests confirming database clearing behavior for on-prem profiles with default DBs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21610 +/- ##
=======================================
Coverage 72.73% 72.73%
=======================================
Files 331 331
Lines 98598 98613 +15
Branches 5481 5483 +2
=======================================
+ Hits 71715 71730 +15
Misses 26883 26883
🚀 New features to boost your workflow:
|
| if (!databaseScopeFilter) { | ||
| databaseScopeFilter = profileToUse.database; | ||
| } | ||
| profileToUse = { ...profileToUse, database: "" }; |
Contributor
There was a problem hiding this comment.
When database is "", it sets the profile to use the default DB?
lewis-sanchez
approved these changes
Mar 13, 2026
Contributor
|
Create an issue to track this, if you're going to port. |
allancascante
deleted the
dev/allancascante/query_profiler_on_prem_default_db
branch
allancascante
added a commit
that referenced
this pull request
Mar 13, 2026
…n the connection profile (#21610) Co-authored-by: Allan Cascante <acascante@microsoft.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When launching a query profiler from a standard on prem db having a default database in the connection profile the query profiler fails to update the ui with the state and events for the profiler session created in the back end.
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines