fix: correct ArrayQueue boundaries in takeWhile and takeFromEndWhile#301119
Open
Muszic wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: correct ArrayQueue boundaries in takeWhile and takeFromEndWhile#301119Muszic wants to merge 1 commit intomicrosoft:mainfrom
Muszic wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two symmetrical boundary bugs in
ArrayQueuewheretakeWhileandtakeFromEndWhilewould ignore the internallastIdxandfirstIdxpointers. If both methods were interleaved on the same queue instance, it would lead to out-of-bounds reading and queue state corruption.Fixes:
takeWhilenow correctly checksstartIdx <= this.lastIdx(previously checked againstthis.items.length).takeFromEndWhilenow correctly checksendIdx >= this.firstIdx(previously checked>= 0).Tests:
Added regression tests to
arrays.test.tsto ensure that mixed calls totakeWhileandtakeFromEndWhilesafely respect the active boundaries of the queue. Also includes the updatedmonaco.d.tsgenerated by the watch task.