Repository navigation
Add -NoCheckout switch to PRTest.ps1 - #440849
Merged
Demitrius Nelon (denelon) merged 2 commits intoSep 26, 2026
Merged
Demitrius Nelon (denelon) merged 2 commits into
Demitrius Nelon (denelon) merged 2 commits into
Conversation
Add a -NoCheckout switch to Tools\PRTest.ps1 that fetches the PR's validated merged manifest from the WinGet Validator artifact instead of checking out the pull request locally. * Resolve the PR head SHA and locate the app-scoped 10. Validation Completed check run * Parse the artifact download URL from the check output and download, extract, and stage the singleton YAML manifest into a folder named for the PR number under $env:TEMP\WinGet-PRTest * Run SandboxTest.ps1 against the staged manifest with -SkipManifestValidation implied * Preserve existing checkout-mode behavior * Document exit codes for missing dependencies, checkout failure, missing validation check, missing artifact URL, and missing YAML
Kaleb Luedtke (Trenly)
marked this pull request as ready for review
September 24, 2026 23:17
Kaleb Luedtke (Trenly)
requested review from
a team and
Demitrius Nelon (denelon)
as code owners
September 24, 2026 23:17
Contributor
Contributor
|
Changes to one or more files in your PR require authorization to modify. This PR has been assigned to our on call staff to evaluate. Template: msftbot/requiresApproval/MSFT |
Ruben Guerrero (msftrubengu)
previously approved these changes
Sep 24, 2026
yao-msft
reviewed
Sep 25, 2026
* Extract only the YAML manifest entry from the validation artifact using [System.IO.Compression.ZipFile] and [System.IO.Compression.ZipFileExtensions]::ExtractToFile(), avoiding extraction of installation verification logs that can hit long-path issues * Nest artifact paths as WinGet-PRTest\<PR>\<headSha>\, retaining artifacts.zip alongside the extracted Manifest folder * Consolidate cleanup to a single upfront removal of the run folder * Support -Clean by removing the entire WinGet-PRTest root folder before retrieving the artifact
Kaleb Luedtke (Trenly)
requested review from
Ruben Guerrero (msftrubengu) and
yao-msft
September 25, 2026 02:11
yao-msft
approved these changes
Sep 25, 2026
Kaleb Luedtke (Trenly)
deleted the
copilot/prtest-no-checkout-artifact
branch
September 26, 2026 01:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
-NoCheckoutswitch toTools\PRTest.ps1. Instead of checking out the pull request locally, it retrieves the pull request's WinGet Validator10. Validation Completedcheck run, downloads the associated validation artifact, extracts only the singleton merged manifest YAML entry, stages it under a PR- and head-SHA-scoped folder in$env:TEMP\WinGet-PRTest, and runsSandboxTest.ps1against it (implying-SkipManifestValidation).Existing checkout-mode behavior is unchanged.
Changes
Tools\PRTest.ps1:-NoCheckoutswitch10. Validation Completedcheck runArtifactDownloadUrlfrom the check output and downloads the artifact[System.IO.Compression.ZipFile]and[System.IO.Compression.ZipFileExtensions]::ExtractToFile(), avoiding extraction of installation verification logs that can hit long-path issuesWinGet-PRTest\<PullRequest>\<headSha>\, retainingartifacts.zipalongside the extractedManifestfolder-Cleanremoves the entireWinGet-PRTestroot folder before retrieving the artifactValidation performed
SandboxTest.ps1stub (no installation launched): resolved the check run, downloaded the artifact, extracted only the single YAML manifest entry (leaving installation verification logs and other result files unextracted in the zip), staged it correctly, and passedSkipManifestValidation = true-Cleanremoves a stale/unrelated prior run folder underWinGet-PRTestbefore processing the requested PR10. Validation Completedcheck resolves correctly for New version: laurentiu021.SysManager version 1.113.14 #440812, New version: agentty.agentty version 0.9.10 #440811, and New version: demkada.ArgyCode version 2.7.3 #440810-NoCheckoutNote
No related open/closed issue was found in microsoft/winget-pkgs, and issue creation requires explicit confirmation per repository conventions that was not available during this session. This PR does not yet link to an issue — please link one or confirm creating a new
feature_request.ymlissue before merge.Generated with assistance from GitHub Copilot.
Checklist