Repository navigation
chore: remove unreliable octet stream benchmarks - #2188
Conversation
The rpc and openapi link + handler octet stream benches flip between two values (~640 µs vs ~728 µs for rpc) across CI runs with no code changes, producing false ±12-14% CodSpeed regressions on unrelated PRs. Remove them and the payload helpers only they used.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
orpc | 93b943e | Commit Preview URL Branch Preview URL |
Oct 06 2026, 06:19 AM |
More templates
@orpc/ai-sdk
@orpc/arktype
@orpc/bun
@orpc/client
@orpc/cloudflare
@orpc/contract
@orpc/experimental-effect
@orpc/evlog
@orpc/hibernation
@orpc/json-schema
@orpc/experimental-lock
@orpc/experimental-msw
@orpc/nest
@orpc/next
@orpc/node
@orpc/openapi
@orpc/opentelemetry
@orpc/pinia-colada
@orpc/pino
@orpc/publisher
@orpc/ratelimit
@orpc/server
@orpc/shared
@orpc/swr
@orpc/tanstack-query
@orpc/trpc
@orpc/valibot
@orpc/zod
commit: |
There was a problem hiding this comment.
Important
Dropping the ReadableStream branch from the shared drainBody helper also changes the static-file benchmarks, which is outside this PR's stated scope and should be addressed before merge.
Reviewed changes
- Removed the two octet stream benches — deleted
bench('octet stream', ...)frombenches/rpc-link-handler.bench.tsandbenches/openapi-link-handler.bench.tsplus their now-unused imports;bufferedandevent streamremain. - Pruned shared payload helpers — removed
asReadableStream,splitBytes,BYTES_1KB/10KB/100KB/5MB, and the unusedSIZE_1KB/10KB/100KB;SIZE_5MBis retained forFILE_BYTES. - Reduced
drainBody— kept only theisAsyncIteratorObjectbranch; theReadableStreamdraining path was removed along with the octet benches.
No dangling references to the removed helpers remain in benches/.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merging this PR will improve performance by 21.35%
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
static-file-handler benches still pass ReadableStream response bodies to drainBody; without this branch they stopped reading the file and under-measured the serve path.
There was a problem hiding this comment.
✅ No new issues found.
The delta since the last review (2456e6a) restores the ReadableStream draining branch in drainBody, which resolves the static-file regression flagged previously. The removal cleanup itself is clean and free of dangling references.
Reviewed changes
- Restored the
ReadableStreamdrain path indrainBody—benches/__shared__/payloads.ts:85-98again consumesReadableStreamresponse bodies, sobenches/static-file-handler.bench.tsonce more measures the full serve path and releases the reader. This was the sole concern from the prior review and is now addressed.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

Removes the `octet stream` benchmarks from the rpc and openapi link + handler suites. They kept producing false CodSpeed regressions and improvements on PRs that don't touch streaming, so CodSpeed reports become trustworthy again.
Why
Testing