Skip to content

Save is_quoted info for double quoted identifier#70

Closed
ea-rus wants to merge 1 commit intomainfrom
double-qoutes-identifier
Closed

Save is_quoted info for double quoted identifier#70
ea-rus wants to merge 1 commit intomainfrom
double-qoutes-identifier

Conversation

@ea-rus
Copy link
Copy Markdown
Collaborator

@ea-rus ea-rus commented Oct 29, 2025

This query should be parsed as quoted and have only one part

select * from "table.name"

@github-actions
Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
mindsdb_sql_parser
   __about__.py10100%1–10
   __init__.py1192282%44, 48, 53, 98, 115, 139–158, 165–166
   lexer.py2832193%373, 375, 377, 389, 391, 393, 399–417
   logger.py19479%14, 17, 23, 26
   parser.py11163097%129, 133, 301, 326, 432, 619, 636, 660–661, 882, 936, 1013, 1114, 1168, 1178, 1247, 1258, 1341, 1417, 1456, 1492, 1688–1689, 1864–1865, 2043, 2051, 2104–2107
   utils.py46491%73–79
mindsdb_sql_parser/ast
   base.py36586%13, 28, 31, 46, 51
   create.py82989%7–8, 23–31, 95
   drop.py52296%10, 13
   insert.py63494%39–41, 46
   show.py48198%18
   update.py53591%40–42, 75–76
mindsdb_sql_parser/ast/mindsdb
   knowledge_base.py118397%79, 118, 128
mindsdb_sql_parser/ast/select
   case.py37197%22
   constant.py36197%23
   data.py11464%10–12, 15, 19
   identifier.py831187%56, 104–112, 122
   native_query.py13192%25
   operation.py139497%57, 66, 178, 202
   parameter.py15287%17, 20
   select.py109397%160–165
   star.py12283%8–9
TOTAL342714996% 

Tests Skipped Failures Errors Time
313 0 💤 0 ❌ 0 🔥 13.980s ⏱️

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

🔒 Entelligence AI Vulnerability Scanner

No security vulnerabilities found!

Your code passed our comprehensive security analysis.

📊 Files Analyzed: 1 files


@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Review Summary

@ea-rus
Copy link
Copy Markdown
Collaborator Author

ea-rus commented Dec 3, 2025

need to confirm if this update is required

@ea-rus ea-rus marked this pull request as draft December 3, 2025 15:00
@ea-rus
Copy link
Copy Markdown
Collaborator Author

ea-rus commented Mar 26, 2026

Removing support of double quotes
#84

@ea-rus ea-rus closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant