Skip to content

Update workflow: Update Vale vocabulary#4486

Closed
mintlify-development[bot] wants to merge 1 commit intomainfrom
workflows/update-update-vale-vocabulary-1773544459973
Closed

Update workflow: Update Vale vocabulary#4486
mintlify-development[bot] wants to merge 1 commit intomainfrom
workflows/update-update-vale-vocabulary-1773544459973

Conversation

@mintlify-development
Copy link
Contributor

@mintlify-development mintlify-development bot commented Mar 15, 2026

Updates the workflow configuration at .mintlify/workflows/update-vale-vocab.md.

Field Before After
Trigger PR merges Scheduled
Schedule 0 0 * * * 0 */6 * * *
Implementation Create PR Automerge

Note

Low Risk
Low risk configuration-only change that adjusts workflow scheduling/notifications; no application logic or data handling is modified.

Overview
Switches the Update Vale vocabulary workflow from a push-based trigger to a cron schedule (every 6 hours) and enables automerge.

Updates Slack notifications to use a channels list (and adds several channels) instead of channel_ids.

Written by Cursor Bugbot for commit 8e1a6f3. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

- "ae-dinner-approve"
- "404-roast"
- "admin"
- "add-a-doc"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong Slack notification key breaks notification delivery

High Severity

The channels key under slack is inconsistent with every other workflow in the repository, which all use channel_ids. This likely means Slack notifications for this workflow will silently fail. Additionally, the values are channel names (e.g., "ae-dinner-approve", "404-roast") rather than Slack channel IDs (e.g., C0AKYE83VV4), which is inconsistent with the established pattern and suggests these may be incorrect test/placeholder values.

Fix in Cursor Fix in Web

push:
- repo: "mintlify/docs"
branch: "main"
cron: "0 */6 * * *"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cron trigger may skip PRs between runs

Medium Severity

The trigger changed from push-based (once per merged PR) to cron-based (every 6 hours), but the workflow body still instructs to process only "the last merged PR." When multiple PRs merge within a 6-hour window, only the most recent one will be processed, and vocabulary words from all other merged PRs will be silently skipped. Every other workflow that references "the last merged PR" uses a push trigger, where the phrasing is correct.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant