Repository navigation
feat(author): the package carries the skill's text, and the skill gives a type file's address off GitHub - #179
Merged
Merged
Conversation
…es a type file's address off GitHub (#178) The Claude app, given a link to the h5p-author skill on GitHub, answered that GitHub's rate limit kept it out: GitHub limits anonymous requests per address on github.com and raw.githubusercontent.com, and a chat app's addresses are shared. The skill then sent a chat that had its text back to raw.githubusercontent.com for a type's file. - `prepack` copies the skill's `SKILL.md` and `references/authoring.md` beside its type files (copy-type-files.mjs is now copy-skill.mjs), each an export, so the organisation's site can serve the skill from the release it pins. - The skill's address for a type's file is the site's, `/h5p/build/types/<Type>.md`, live since the build page carries the type files. Installing the skill stays the way: nothing is fetched while the chat works. The package test holds the copies to the skill's files and finds them through the exports; dropping either copy fails it. The tarball gains SKILL.md and references/authoring.md and nothing else. 179 author tests and 77 skills tests pass.
Contributor
There was a problem hiding this comment.
1 issue found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="skills/h5p-author/SKILL.md">
<violation number="1" location="skills/h5p-author/SKILL.md:63">
P2: This fallback URL is added before the separate site change that serves `/build/types/<Type>.md` is deployed, so users of the released skill can hit a missing page. Deploy the file-serving route before publishing this skill, or keep the fallback on the existing source until that route is live.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| content holds have files too: H5P.AdvancedText, H5P.Image, H5P.Video, H5P.Text. With this text | ||
| alone and no file beside it, open the file at | ||
| `https://raw.githubusercontent.com/missing-elements/h5p-offline-player/main/skills/h5p-author/references/types/<Type>.md`; | ||
| `https://missing-elements.github.io/h5p/build/types/<Type>.md`; |
Contributor
There was a problem hiding this comment.
P2: This fallback URL is added before the separate site change that serves /build/types/<Type>.md is deployed, so users of the released skill can hit a missing page. Deploy the file-serving route before publishing this skill, or keep the fallback on the existing source until that route is live.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At skills/h5p-author/SKILL.md, line 63:
<comment>This fallback URL is added before the separate site change that serves `/build/types/<Type>.md` is deployed, so users of the released skill can hit a missing page. Deploy the file-serving route before publishing this skill, or keep the fallback on the existing source until that route is live.</comment>
<file context>
@@ -60,7 +60,7 @@ the same package.
content holds have files too: H5P.AdvancedText, H5P.Image, H5P.Video, H5P.Text. With this text
alone and no file beside it, open the file at
-`https://raw.githubusercontent.com/missing-elements/h5p-offline-player/main/skills/h5p-author/references/types/<Type>.md`;
+`https://missing-elements.github.io/h5p/build/types/<Type>.md`;
where nothing opens, write the source from what you know of the type: the build says, for each
place that is wrong, what to write there.
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #178.
The Claude app, given a link to the h5p-author skill on GitHub, answered "I couldn't access the GitHub SKILL.md file due to rate limiting". GitHub limits anonymous requests per address on github.com and raw.githubusercontent.com, and a chat app fetches through addresses many users share. The skill then sent a chat that had its text back to raw.githubusercontent.com for a type's file.
Installing the skill stays the way: uploaded to the Claude app, added with
npx skills add, pasted as a Chrome skill's prompt, nothing is fetched while the chat works. This is for a chat that cannot install one.What changes
prepackcopiesSKILL.mdandreferences/authoring.mdbeside the type files (scripts/copy-type-files.mjsis nowcopy-skill.mjs), each an export:@missing-elements/h5p-author/SKILL.md,@missing-elements/h5p-author/references/authoring.md. The organisation's site then serves the skill from the release its build page pins, in a pull request of its own.https://missing-elements.github.io/h5p/build/types/<Type>.md, live since the build page carries the type files, in place of raw.githubusercontent.com's..gitignore, the package README,design/author.mdanddesign/layout.mdsay so.Tested
pnpm --filter @missing-elements/h5p-author test: 179 pass. The package test runs the copy, holdsSKILL.md, the brief and every type file to the skill's own, and resolves each through the exports; dropping either new copy fails it. The typecheck passes.pnpm --filter @missing-elements/h5p-skills test: 77 pass.pnpm pack: the tarball is 0.8.0's files andSKILL.mdandreferences/authoring.md.To release
h5p-author 0.9.0, a minor for the two exports. Then the site's pull request serves the skill at
missing-elements.github.io/h5p/skill/, with a page listing every file's full address: a chat's fetch tool may open only addresses it has seen whole, which a relative link or<Type>is not.Summary by cubic
The
h5p-authorpackage now carries the skill's text (SKILL.mdandreferences/authoring.md) alongside its type files, so the organization's site can serve the skill from a pinned release. The skill's type-file address changes fromraw.githubusercontent.comtohttps://missing-elements.github.io/h5p/build/types/<Type>.md, avoiding GitHub's per-address rate limits that blocked chat apps from fetching skill files. Installing the skill stays as before; nothing is fetched while the chat works.To release
h5p-author0.9.0 as a minor for the two new exports.missing-elements.github.io/h5p/skill/with a page listing each file's full address, so a chat's fetch tool can open them.Written for commit 8ab63db. Summary will update on new commits.