Repository navigation
List the build tool and every bundle on the skill page - #18
Merged
Merged
Conversation
/h5p/skill/ wrote out the full address of each of the skill's files but none of the files its step 3 fetches where npm cannot be reached, so a chat with the skill's text alone had to put a bundle's address together from its type, which a fetch tool may refuse. The page now lists h5p-author.mjs and every bundle /h5p/bundles/ serves, each at its full address as its link and its text, named by the author package's contentTypes, the list writeBundles writes from. The SKILL.md test no longer expects the type-file address 0.9.0 names, so the pin can move to the next release without changing it. Closes #17
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
The SKILL.md test stopped expecting 0.9.0's type-file address so the pin could move, and with it any check that the skill gives a way to a type's file at all (cubic's review). It now asks for 0.9.0's address of its own or this page, which writes each one out, as the next release names it. SKILL.md with neither fails it.
This was referenced Nov 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17.
/h5p/skill/wrote out the full address of each of the h5p-author skill's files, but none of the files its step 3 fetches where npm cannot be reached. A chat with the skill's text alone had to put a bundle's address together from its type, and a fetch tool may refuse that: an outside review of the skill had…/bundles/H5P.Blanks.ziprefused so. missing-elements/h5p-offline-player#180 sends such a chat to this page for every address.What changes
src/_data/skill.jsnames them by the author package'scontentTypes, the list itswriteBundleswrites from, so the page, written before Vite writes the bundles, keeps no copy of the rule. Both are public exports of h5p-author 0.9.0: this needs no release and can merge first./h5p/build/types/<Type>.md, which 0.9.0 names and the next release does not; it still fetches every address SKILL.md gives. So the pin can move without changing the test.vite.config.tssays the page names the bundles.Tested
pnpm build,pnpm typecheck,pnpm e2e: 16 pass. The new test holds the page's bundle links to/h5p/bundles/index.json, which Vite wrote: a page missing a bundle, or writing an address that is not whole, fails it (both tried).Summary by cubic
The skill page now lists the build tool and every bundle it serves at their full addresses, so a chat that cannot reach npm can fetch the files step 3 of
SKILL.mdnames without assembling bundle addresses from type names.h5p-author.mjsand every bundle after the type files, each at its full address as its link and its text, named from the author package'scontentTypes— the same listwriteBundleswrites from — so the page keeps no copy of the rule and this needs no release./h5p/build/types/<Type>.md, which h5p-author 0.9.0 names and the next release does not, and it holds the skill to a way to a type's file — 0.9.0's address or this page, which writes each one out — so the pin can move without changing the test.Closes #17.
Written for commit 8c7bd4c. Summary will update on new commits.