Repository navigation
Pin h5p-author 0.9.2 - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22.
h5p-author 0.9.2 (missing-elements/h5p-offline-player#183) changes the skill's text and the generated section of every content type's file: the skill asks the user for the content type, then for the author and licence, which they may skip, before it writes a source, and each content type's file says a source also names its own
title,language,licenseandauthors. The build does not change.What changes
package.jsonand the lockfile:@missing-elements/h5p-author0.9.1 → 0.9.2. The lockfile change is the four lines of that entry, with the integrity npm gives for 0.9.2./h5p/skill/SKILL.mdand the brief are 0.9.2's, and so are the 28 content types' files, under/h5p/skill/and/h5p/build/types/. The four parts' files (H5P.AdvancedText, H5P.Image, H5P.Text, H5P.Video) are as in 0.9.1. The page names h5p-author 0.9.2, and/h5p/bundles/index.jsonsays author 0.9.2, with the same 55 bundles from pack 1.1.0.Tested
pnpm build,pnpm typecheckandpnpm e2e: 16 pass. After the build,_site/h5p/skill/SKILL.md,references/authoring.mdand all 32 type files, under/h5p/skill/and/h5p/build/types/, are byte for byte the files of the published 0.9.2 tarball.Summary by cubic
Pins
@missing-elements/h5p-authorto 0.9.2 and regenerates the skill and content type files that ship with the build.title,language,license, andauthors.pnpm build,pnpm typecheck, andpnpm e2e(16 tests pass).Written for commit dc5fdf6. Summary will update on new commits.