Conversation
…restriction Zod v4 throws ".pick() cannot be used on object schemas containing refinements", which broke parseStixBundles top-level id/type check against stixBundleSchema. Split the bundle schema into a refinement-free base (stixBundleBaseSchema) and the refined stixBundleSchema, and pick from the base.
|
🎉 This PR is included in version 4.11.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67.
Summary
parseStixBundlevalidates a bundle's top-levelidandtypeby callingstixBundleSchema.pick({ id: true, type: true }). Zod v4 disallows.pick()on any schema that has refinements attached, andstixBundleSchemacarries three (validateXMitreCollection,validateXMitreContentsReferences,validateNoDuplicates). As a result, every call intoregisterDataSource/loadDataModelthrew:Fix
Split
stixBundleSchemainto two exports:stixBundleBaseSchema— the plainz.object({...}).strict()shape, no refinements. Safe to compose with.pick(),.extend(), etc.stixBundleSchema—stixBundleBaseSchema.check(...)with the existing collection/contents/duplicate refinements. Used for full bundle validation, unchanged.parseStixBundlenow picksidandtypefromstixBundleBaseSchema, which sidesteps the Zod v4 restriction without weakening any validation: the top-level check was always meant to be a shallow gate (note the existing.loose()soobjectspasses through to per-object validation), and full bundle validation viastixBundleSchemais still available to callers that want it.Test plan
npx vitest run test/objects/stix-bundle.test.ts— 23/23 passnpx vitest run test/documentation/README.test.ts— 13/13 pass (exercises theregisterDataSource→loadDataModelpath from the bug report)npx tsc --noEmitclean