Skip to content

Change arg parsing to reduce confusion for CLOSED#361

Open
FileSystemGuy wants to merge 4 commits intomainfrom
FileSystemGuy-argparse-changes
Open

Change arg parsing to reduce confusion for CLOSED#361
FileSystemGuy wants to merge 4 commits intomainfrom
FileSystemGuy-argparse-changes

Conversation

@FileSystemGuy
Copy link
Copy Markdown
Contributor

Change the argument parsing in mlpstorage to reduce confusion on which arguments are permitted and which are required for each of the various workloads and submission types (eg: closed versus open). It moves to a dynamically-created arg structure where the earlier arguments determine the later arguments.

Require the first argument to be "closed" or "open" with it defaulting to "closed' if the argument is missing. The rest of the argument parsing code then is built taking that into account. Args that cannot be changed in closed are not allowed on the command line and their values are defaulted, while open allows all the args to be changed. As such, it should reduce the load on the submission validation checker, and reduce submitter confusion.

Include a unit test of the cli parsing code to validate that it is doing the correct thing. This is not a comprehensive test, it lacks negative tests.

@russfellows and @idevasena and @dslik will need to look at the list of args that are accepted in each mode.

This is a late-in-the-day change, so feel free to say that it conflicts with too many things and should be put off until after 3.0.

There isn't a good way to run the CI/CD test flow against a branch without creating a PR, so this may fail those tests and need adjustment.

@github-actions
Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@FileSystemGuy
Copy link
Copy Markdown
Contributor Author

Well... Evidently I need to make it a real PR rather than a draft PR to engage the CI/CD testing.

@FileSystemGuy FileSystemGuy marked this pull request as ready for review April 29, 2026 00:20
@FileSystemGuy FileSystemGuy requested a review from a team April 29, 2026 00:20
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
@FileSystemGuy FileSystemGuy reopened this Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant