Repository navigation
Conversation
tas0dev
marked this pull request as ready for review
November 11, 2026 08:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a default-branch-only
Initialize Edit signingworkflow protected by the existing application-maintainers Environment approval. It downloads a selected successful main package run, uses pinned trusted DevKit tooling without an application checkout, and performs runner-only Edit key creation, Kome device login, certificate issuance, package signing/verification and atomic Environment Secret storage.Use official Developer
019f9e5ac6687902b0e72fe53abfbef1and packageorg.mochios.edit. A short-lived Edit-only fine-grained PAT with Environment read/write is provided asSIGNING_SETUP_TOKEN; the helper removes that Secret after success, and the operator then revokes the PAT in GitHub settings. Interrupted issuance retains an encrypted recovery keypair so retrying cannot silently rotate the key. No private credential artifact upload exists, and no Root/Intermediate private key is needed.Update the package publisher to consume
MSIGN_IDENTITY_B64. Publication stays disabled, and neither this PR nor initialization releases software. After review/merge and a successful main package build, dispatch setup with that run ID, approve the Environment, and follow the public Kome login URL in the running step. See BUILDING.md for the concrete procedure.Validation: common helper tests and trusted tooling builds are checked in DevKit; the pinned Edit package build is checked by this PR. Actual initialization is intentionally not run from staging/PR or bypassed around approval.
Final verification: https://github.com/mochiOS/Edit.app/actions/runs/42988089358 succeeded, including the real read-only job token reading the required Team/branch policy, 14 host tests, native build, MPKG generation and upload. The final downloaded artifact matches SDK 0f8585f and GitHub PR test-merge 954ae59; all 11 payload hashes/sizes and runner-path checks passed, and resolved Cargo.lock exactly matches the committed file. Publication was skipped. Common tooling passed: https://github.com/mochiOS/devkit/actions/runs/42987419911 (20 Python, 28 msign, 52 Kome tests).