Repository navigation
fix(client): include HTTP status and reason in streamable HTTP error data - #3870
tang-ontheway wants to merge 1 commit into
Conversation
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3857. If a maintainer assigns you to #3857, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
Summary
When a server or proxy responds with a non-2xx HTTP status (other than 404) without a JSON-RPC error body,
StreamableHTTPTransportpreviously returned a genericErrorData(code=INTERNAL_ERROR, message="Server returned an error response")withdata=None, dropping the HTTP status code and reason phrase.Changes
data={"http_status": response.status_code, "reason": response.reason_phrase}to the fallbackErrorDatainsrc/mcp/client/streamable_http.pywhile keepingmessage="Server returned an error response"unchanged for backwards compatibility with existing error-matching callers and troubleshooting tests.test_http_error_status_sends_jsonrpc_errorintests/client/test_notification_response.pyto assertexc_info.value.error.datacarrieshttp_statusandreason.Verification
uv run pytest tests/client/test_notification_response.py tests/docs_src/test_troubleshooting.py tests/client/test_streamable_http.py(77 passed)Fixes #3857