Skip to content

fix(client): include HTTP status and reason in streamable HTTP error data - #3870

Closed
tang-ontheway wants to merge 1 commit into
modelcontextprotocol:mainfrom
tang-ontheway:fix/streamable-http-error-status-data
Closed

tang-ontheway wants to merge 1 commit into
modelcontextprotocol:mainfrom
tang-ontheway:fix/streamable-http-error-status-data

Conversation

@tang-ontheway

Copy link
Copy Markdown

Summary

When a server or proxy responds with a non-2xx HTTP status (other than 404) without a JSON-RPC error body, StreamableHTTPTransport previously returned a generic ErrorData(code=INTERNAL_ERROR, message="Server returned an error response") with data=None, dropping the HTTP status code and reason phrase.

Changes

  • Attach data={"http_status": response.status_code, "reason": response.reason_phrase} to the fallback ErrorData in src/mcp/client/streamable_http.py while keeping message="Server returned an error response" unchanged for backwards compatibility with existing error-matching callers and troubleshooting tests.
  • Update test_http_error_status_sends_jsonrpc_error in tests/client/test_notification_response.py to assert exc_info.value.error.data carries http_status and reason.

Verification

  • uv run pytest tests/client/test_notification_response.py tests/docs_src/test_troubleshooting.py tests/client/test_streamable_http.py (77 passed)

Fixes #3857

@github-actions github-actions Bot added the missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md) label Nov 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3857.

If a maintainer assigns you to #3857, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take.

You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way.

CONTRIBUTING.md has the full reasoning, but in short:

  • We're a small team with very little capacity to review community PRs right now.
  • Many recent PRs are AI-generated with little human review, and reviewing one carefully still costs a maintainer as much time as it ever did. A well-described issue is usually more useful to us than the code.

Maintainers: reopen, remove missing-issue-link, or add bypass-issue-check to override.

@github-actions github-actions Bot closed this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Streamable HTTP client drops the HTTP status of an error response

1 participant