Repository navigation
Conversation
Contributor
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and this PR doesn't link an open issue yet.
You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
extract_field_from_www_auth()buildsrf'{field_name}=(?:"([^"]+)"|([^\s,]+))'and runsre.searchover the whole header, so the requested parameter name matches in three unintended places:x_scope="admin", scope="files:read", asking forscopereturnsadmin(andx_resource_metadata=redirects RFC 9728 discovery to another URL);error_description="... scope=admin ..."answers forscope;scope=""returns the two quote characters) or a quoted-pair escape (scope="a\"b"truncates at the backslash).The extracted
scopefeeds the authorization request (and the SEP-2350 step-up union) and the extractedresource_metadatafeeds discovery URL selection, so both follow a decoy parameter.Fix
Parse the header into auth-params (token
=( token / quoted-string ), RFC 7235 §2.1), honouring quoted-pair escapes and empty quoted values, and look up the requested name exactly.Tests
tests/client/test_auth.pygains cases for suffix names, text inside a quoted value, empty quoted values, escaped quotes and unterminated quotes. A standalone script reproduces the behaviour before/after (exit 1 -> 0); the header parser is covered by the added tests.