Repository navigation
Conversation
…bject tools/call and prompts/get raised NoMethodError on a non-object arguments value, so the client got -32603 Internal error and the exception reporter saw a server fault for a client mistake.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/callwith"arguments": "x"(or an array or a number) raisedNoMethodErrorinsidecall_tool. The client got-32603 Internal error, and the server'sexception_reporterreceived theNoMethodErroras if it were a server bug.prompts/getdid the same.The MCP schema requires
argumentsto be an object, and JSON-RPC defines-32602 Invalid paramsfor this. Both handlers now refuse a non-object value withRequestHandlerErroranderror_type: :invalid_params, as the unknown-tool case does. A missingargumentsstill works as before.Reproduced on 1.10.0. The new tests fail on main and pass with the change.
rake testandrake rubocoppass.