Repository navigation
Conversation
… cap The documented caps bound how many thoughts are retained and what one thought draws on stderr. Nothing bounds the size of a single thought or branchId. Pin that through the in-process client, with thought logging off and on: a 1,000,000-character thought and a 5,000-line thought are each accepted and counted once, and a 10,000-character branchId is listed verbatim, also by a later response. Tests only; no behavior change, so no changeset. Closes #5543 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com>
|
|
| Tools | Prompts | Resources | Resource templates | |
|---|---|---|---|---|
| Base | 1 | 0 | 0 | 0 |
| Head | 1 | 0 | 0 | 0 |
Updated by this run for 5b5531fb9ea3400623028bccf50b46134b4a356c.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for this test-only change covering large thoughts and branch IDs.
No open issues 🎉
What changed in this PR
Adds test-only coverage for #5543, characterizing the sequentialthinking server’s current lack of per-item size limits so future caps require deliberate test updates. No production code changes.
Changes:
- Checks that million-character and 5,000-line thoughts are accepted and each counts once in history.
- Verifies that a 10,000-character branch ID appears verbatim in both immediate and later responses.
- Runs all three cases with thought logging disabled and enabled, suppressing stderr output.
| File | Description |
|---|---|
src/sequentialthinking/__tests__/item-size.test.ts |
Adds six in-process MCP characterization cases covering large inputs across both logging modes. |
Review effort: Balanced
|
Copilot round 1: clean. The review recorded no findings and no suppressed comments, so the loop ends here on the first clean round. Nothing was pushed after the review. Not merged: merging is the maintainer's call. |
Closes #5543
Description
Adds
src/sequentialthinking/__tests__/item-size.test.ts: characterization tests pinning that the server has no per-item size cap today. Tests only; no source file changes.The server's documented caps are on other dimensions:
MAX_THOUGHT_HISTORYbounds how many thoughts are retained, andMAX_BOX_TEXT_WIDTH/MAX_BOX_ROWSbound what one thought draws on stderr. The size of a singlethoughtorbranchIdis unbounded: both are a barez.string()in the input schema, and the history keeps each whole.The three cases from the issue, driven through the in-process MCP client:
branchIdis accepted and listed verbatim inbranches, by the call that records it and by a later, unbranched call.Two differences from the issue's proposal:
thinking.test.ts, so the characterization is easy to find and to delete or rewrite if a cap is ever introduced.The tests take no position on whether a cap should exist.
Server Details
sequentialthinkingMotivation and Context
See #5543. If a per-item cap is added later, these tests fail, so the change is deliberate and visible rather than a silent side effect.
How Has This Been Tested?
No client-observable surface changes, so the evidence is a targeted probe.
v2/main@7f383a8ethe new file passes, 6 of 6 (3 cases × logging off/on).z.string().max(100000)onthoughtandz.string().max(256)onbranchIdinindex.ts, 4 of 6 fail (the million-character thought and the longbranchId, in both logging modes). The 5,000-line thought is 25,000 characters, so it is the case that would catch a line-count cap rather than a character cap. The plant was reverted; the diff holds the test file only.npm run local:gateexits 0.Breaking Changes
None.
Types of changes
None of the four: test-only.
Checklist
npm run changeset) if this changes what a TypeScript server publishes (not applicable: nothing published changes)🤖 Generated with Claude Code