Skip to content

ci: rename everything-mcp-diff.yml to mcp-interface-diff.yml (step 2) - #5614

Open
cliffhall wants to merge 1 commit into
v2/mainfrom
v2/chore/5527-mcp-interface-diff-rename
Open

cliffhall wants to merge 1 commit into
v2/mainfrom
v2/chore/5527-mcp-interface-diff-rename

Conversation

@cliffhall

Copy link
Copy Markdown
Member

Closes #5527

Description

Step 2 of the workflow rename staged in #5463. The MCP interface diff now lives in .github/workflows/mcp-interface-diff.yml, and everything-mcp-diff.yml is deleted.

  • mcp-interface-diff.yml takes the diff's full contents (the push, pull_request, release and workflow_dispatch triggers), replacing the dispatch-only placeholder. Its two gh run list --workflow calls name the new file, and its header records how the rename was staged.
  • version-packages.yml and prepare-python-release.yml dispatch mcp-interface-diff.yml (and the Prepare Python Release PR body names it).
  • TOOLING_PATHS in scripts/lib/interface-diff-servers.mjs names the new file.
  • scripts/version-pr-ci.test.mjs pins the new name in its tables. The Step 1 test ("is a dispatch-only placeholder until Step 2") is replaced by one that pins the end state: the old file is gone, no workflow's executable lines name it, and the new file has all four triggers.
  • RELEASING.md, the release skill, docs/quality-gate.md and the AGENTS.md tree name the new file.

The workflow's name: (MCP Interface Diff), its job names, the Interface diff (dispatched) status context and the sticky comment marker are unchanged.

Server Details

None (repository-wide): CI workflows, gate tooling and docs.

Motivation and Context

#5527. The file diffs every server since #5428 but was still named for Everything. GitHub dispatches a workflow only when its file exists on the default branch, so the rename needed the new name on main first.

Preconditions, checked before starting:

Rulesets: no human step needed. No ruleset names an interface diff check. The only required status check in the repository is Source is v2/main on main: milestone merges only; v2/main: PRs only requires none, and neither branch has classic branch protection.

Until the next milestone merge, main still holds its own everything-mcp-diff.yml. Nothing dispatches it after this PR, and the v2.6.0 merge PR deletes it there (its runs come from the PR's merge commit, which has only the new file).

How Has This Been Tested?

No client-observable surface, so targeted probes:

  • The guard fires on a planted defect, then passes. node --test scripts/version-pr-ci.test.mjs: 29 pass. With version-packages.yml's loop put back on everything-mcp-diff.yml: 2 fail (the new end-state test and the dispatch-list test). With the old file restored beside the new one: 1 fail (the end-state test). Both reverted: 29 pass.
  • The selection still treats the workflow as tooling. npm run interface-diff -- --base origin/v2/main --list selects all seven servers.
  • npm run local:gate exits 0 on the pushed commit, including interface-diff for all seven servers (no interface changes).
  • This PR's own run is the first pull_request run of the real diff under the new file name; its Choose the servers to diff and Diff <server> jobs appear in the checks below.
  • Not exercised here: the dispatch from a version workflow. Both run only from v2/main, so the first version PR after this merges is the live check that Interface diff (dispatched) still appears. The by-hand equivalent after merge is gh workflow run mcp-interface-diff.yml --ref <branch>.

Breaking Changes

None. No server or published package changes.

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update (and CI maintenance)

Checklist

  • I have read the MCP Protocol Documentation (not applicable: no protocol feature is touched)
  • My changes follow MCP security best practices (the workflow's permissions and job split are unchanged)
  • I have updated the server's README accordingly (not applicable: no server changes)
  • I have added a changeset (not applicable: nothing a TypeScript server publishes changes)
  • I have tested this with an LLM client (not applicable: no server-facing change; probes above)
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling (not applicable: no new code paths)
  • I have documented all environment variables and configuration options (not applicable: none added)

🤖 Generated with Claude Code

Step 2 of the rename staged in #5463. The placeholder shipped to main in
the v2.5.0 milestone merge, so GitHub can dispatch the new file name.

- Move the interface diff's contents into mcp-interface-diff.yml, with
  its push, pull_request, release and workflow_dispatch triggers, and
  delete everything-mcp-diff.yml.
- Point both version workflows' dispatch loops, and the diff's own
  `gh run list --workflow` calls, at the new name.
- Update TOOLING_PATHS, the version PR CI test (which now pins the end
  state instead of the placeholder), RELEASING.md, the release skill,
  docs/quality-gate.md and the AGENTS.md tree.

Closes #5527

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: cliffhall <cliff@futurescale.com>
@github-actions

Copy link
Copy Markdown
Contributor

git: MCP interface diff

Base: 7f383a8e0f34 (Merge pull request #5597 from modelcontextprotocol/changeset-release/v2/main)
Head: the build in this checkout, at 8bfdf81d169f (Merge f6e25d4 into 7f383a8)

Diffed because it was named (--server).

✅ No interface changes detected.

Tools Prompts Resources Resource templates
Base 14 2 0 0
Head 14 2 0 0

Updated by this run for f6e25d49d08a930faa99f81cb2cb25b42cbe0592.

@github-actions

Copy link
Copy Markdown
Contributor

everything: MCP interface diff

Base: 7f383a8e0f34 (Merge pull request #5597 from modelcontextprotocol/changeset-release/v2/main)
Head: the build in this checkout, at 8bfdf81d169f (Merge f6e25d4 into 7f383a8)

Diffed because it was named (--server).

✅ No interface changes detected.

Tools Prompts Resources Resource templates
Base 22 4 8 5
Head 22 4 8 5

Updated by this run for f6e25d49d08a930faa99f81cb2cb25b42cbe0592.

@github-actions

Copy link
Copy Markdown
Contributor

memory: MCP interface diff

Base: 7f383a8e0f34 (Merge pull request #5597 from modelcontextprotocol/changeset-release/v2/main)
Head: the build in this checkout, at 8bfdf81d169f (Merge f6e25d4 into 7f383a8)

Diffed because it was named (--server).

✅ No interface changes detected.

Tools Prompts Resources Resource templates
Base 9 0 1 0
Head 9 0 1 0

Updated by this run for f6e25d49d08a930faa99f81cb2cb25b42cbe0592.

@github-actions

Copy link
Copy Markdown
Contributor

time: MCP interface diff

Base: 7f383a8e0f34 (Merge pull request #5597 from modelcontextprotocol/changeset-release/v2/main)
Head: the build in this checkout, at 8bfdf81d169f (Merge f6e25d4 into 7f383a8)

Diffed because it was named (--server).

✅ No interface changes detected.

Tools Prompts Resources Resource templates
Base 3 0 0 0
Head 3 0 0 0

Updated by this run for f6e25d49d08a930faa99f81cb2cb25b42cbe0592.

@github-actions

Copy link
Copy Markdown
Contributor

filesystem: MCP interface diff

Base: 7f383a8e0f34 (Merge pull request #5597 from modelcontextprotocol/changeset-release/v2/main)
Head: the build in this checkout, at 8bfdf81d169f (Merge f6e25d4 into 7f383a8)

Diffed because it was named (--server).

✅ No interface changes detected.

Tools Prompts Resources Resource templates
Base 16 0 0 1
Head 16 0 0 1

Updated by this run for f6e25d49d08a930faa99f81cb2cb25b42cbe0592.

@github-actions

Copy link
Copy Markdown
Contributor

fetch: MCP interface diff

Base: 7f383a8e0f34 (Merge pull request #5597 from modelcontextprotocol/changeset-release/v2/main)
Head: the build in this checkout, at 8bfdf81d169f (Merge f6e25d4 into 7f383a8)

Diffed because it was named (--server).

✅ No interface changes detected.

Tools Prompts Resources Resource templates
Base 1 1 0 0
Head 1 1 0 0

Updated by this run for f6e25d49d08a930faa99f81cb2cb25b42cbe0592.

@github-actions

Copy link
Copy Markdown
Contributor

sequentialthinking: MCP interface diff

Base: 7f383a8e0f34 (Merge pull request #5597 from modelcontextprotocol/changeset-release/v2/main)
Head: the build in this checkout, at 8bfdf81d169f (Merge f6e25d4 into 7f383a8)

Diffed because it was named (--server).

✅ No interface changes detected.

Tools Prompts Resources Resource templates
Base 1 0 0 0
Head 1 0 0 0

Updated by this run for f6e25d49d08a930faa99f81cb2cb25b42cbe0592.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the repository-wide interface-diff workflow rename.

No open issues 🎉

What changed in this PR

Completes Step 2 of #5527’s staged workflow rename, giving the repository-wide MCP interface diff a name that reflects its coverage of all seven servers. No server or published package behavior changes.

Changes:

  • Replaces the new-name placeholder with the full workflow and deletes the old file, preserving triggers, job names, status context, and comment markers.
  • Updates version-workflow dispatches, run lookups, and server-selection tooling to use the new filename.
  • Adds end-state regression checks and updates release and quality-gate documentation.
File Description
scripts/​version-pr-ci.test.mjs Updates expected filenames and checks old-name removal and all four triggers.
scripts/​lib/​interface-diff-servers.mjs Recognizes the renamed workflow as tooling affecting every server.
scripts/​interface-diff.mjs Updates the workflow filename in a comment only.
RELEASING.md Updates the manual dispatch instructions.
docs/​quality-gate.md Updates CI and gate workflow references.
AGENTS.md Updates the repository tree to reflect the completed rename.
.github/​workflows/​version-packages.yml Dispatches the renamed interface-diff workflow.
.github/​workflows/​prepare-python-release.yml Updates the dispatch target and generated PR instructions.
.github/​workflows/​mcp-interface-diff.yml Replaces the placeholder with the full workflow and updates run lookups.
.github/​workflows/​everything-mcp-diff.yml Deletes the old workflow file.
.claude/​skills/​release/​SKILL.md Updates the release procedure’s manual dispatch reference.

Review effort: Balanced

@cliffhall

Copy link
Copy Markdown
Member Author

Copilot round 1: clean (review 5962487087, "No open issues", no inline or suppressed comments). The loop ends here on the first clean round; nothing was pushed after it.

Two live probes since the PR opened, both on f6e25d49:

  • This PR's own pull_request run (44367152464) ran from .github/workflows/mcp-interface-diff.yml: all seven Diff <server> legs and their sticky comments passed, and no run of everything-mcp-diff.yml started beside it.
  • The dispatch the version workflows make, by hand: gh workflow run mcp-interface-diff.yml --ref v2/chore/5527-mcp-interface-diff-rename was accepted and ran the real diff (44368054647, workflow_dispatch, success), posting Interface diff (dispatched) as pending and then success on the commit. That covers the "not exercised here" item in the body, except for the dispatch being made by a version workflow's own token.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: rename everything-mcp-diff.yml to mcp-interface-diff.yml, staged across a milestone merge [Step 2]

2 participants