Repository navigation
Conversation
Step 2 of the rename staged in #5463. The placeholder shipped to main in the v2.5.0 milestone merge, so GitHub can dispatch the new file name. - Move the interface diff's contents into mcp-interface-diff.yml, with its push, pull_request, release and workflow_dispatch triggers, and delete everything-mcp-diff.yml. - Point both version workflows' dispatch loops, and the diff's own `gh run list --workflow` calls, at the new name. - Update TOOLING_PATHS, the version PR CI test (which now pins the end state instead of the placeholder), RELEASING.md, the release skill, docs/quality-gate.md and the AGENTS.md tree. Closes #5527 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com>
|
| Tools | Prompts | Resources | Resource templates | |
|---|---|---|---|---|
| Base | 14 | 2 | 0 | 0 |
| Head | 14 | 2 | 0 | 0 |
Updated by this run for f6e25d49d08a930faa99f81cb2cb25b42cbe0592.
|
| Tools | Prompts | Resources | Resource templates | |
|---|---|---|---|---|
| Base | 22 | 4 | 8 | 5 |
| Head | 22 | 4 | 8 | 5 |
Updated by this run for f6e25d49d08a930faa99f81cb2cb25b42cbe0592.
|
| Tools | Prompts | Resources | Resource templates | |
|---|---|---|---|---|
| Base | 9 | 0 | 1 | 0 |
| Head | 9 | 0 | 1 | 0 |
Updated by this run for f6e25d49d08a930faa99f81cb2cb25b42cbe0592.
|
| Tools | Prompts | Resources | Resource templates | |
|---|---|---|---|---|
| Base | 3 | 0 | 0 | 0 |
| Head | 3 | 0 | 0 | 0 |
Updated by this run for f6e25d49d08a930faa99f81cb2cb25b42cbe0592.
|
| Tools | Prompts | Resources | Resource templates | |
|---|---|---|---|---|
| Base | 16 | 0 | 0 | 1 |
| Head | 16 | 0 | 0 | 1 |
Updated by this run for f6e25d49d08a930faa99f81cb2cb25b42cbe0592.
|
| Tools | Prompts | Resources | Resource templates | |
|---|---|---|---|---|
| Base | 1 | 1 | 0 | 0 |
| Head | 1 | 1 | 0 | 0 |
Updated by this run for f6e25d49d08a930faa99f81cb2cb25b42cbe0592.
|
| Tools | Prompts | Resources | Resource templates | |
|---|---|---|---|---|
| Base | 1 | 0 | 0 | 0 |
| Head | 1 | 0 | 0 | 0 |
Updated by this run for f6e25d49d08a930faa99f81cb2cb25b42cbe0592.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the repository-wide interface-diff workflow rename.
No open issues 🎉
What changed in this PR
Completes Step 2 of #5527’s staged workflow rename, giving the repository-wide MCP interface diff a name that reflects its coverage of all seven servers. No server or published package behavior changes.
Changes:
- Replaces the new-name placeholder with the full workflow and deletes the old file, preserving triggers, job names, status context, and comment markers.
- Updates version-workflow dispatches, run lookups, and server-selection tooling to use the new filename.
- Adds end-state regression checks and updates release and quality-gate documentation.
| File | Description |
|---|---|
scripts/version-pr-ci.test.mjs |
Updates expected filenames and checks old-name removal and all four triggers. |
scripts/lib/interface-diff-servers.mjs |
Recognizes the renamed workflow as tooling affecting every server. |
scripts/interface-diff.mjs |
Updates the workflow filename in a comment only. |
RELEASING.md |
Updates the manual dispatch instructions. |
docs/quality-gate.md |
Updates CI and gate workflow references. |
AGENTS.md |
Updates the repository tree to reflect the completed rename. |
.github/workflows/version-packages.yml |
Dispatches the renamed interface-diff workflow. |
.github/workflows/prepare-python-release.yml |
Updates the dispatch target and generated PR instructions. |
.github/workflows/mcp-interface-diff.yml |
Replaces the placeholder with the full workflow and updates run lookups. |
.github/workflows/everything-mcp-diff.yml |
Deletes the old workflow file. |
.claude/skills/release/SKILL.md |
Updates the release procedure’s manual dispatch reference. |
Review effort: Balanced
|
Copilot round 1: clean (review 5962487087, "No open issues", no inline or suppressed comments). The loop ends here on the first clean round; nothing was pushed after it. Two live probes since the PR opened, both on
|
Closes #5527
Description
Step 2 of the workflow rename staged in #5463. The MCP interface diff now lives in
.github/workflows/mcp-interface-diff.yml, andeverything-mcp-diff.ymlis deleted.mcp-interface-diff.ymltakes the diff's full contents (thepush,pull_request,releaseandworkflow_dispatchtriggers), replacing the dispatch-only placeholder. Its twogh run list --workflowcalls name the new file, and its header records how the rename was staged.version-packages.ymlandprepare-python-release.ymldispatchmcp-interface-diff.yml(and the Prepare Python Release PR body names it).TOOLING_PATHSinscripts/lib/interface-diff-servers.mjsnames the new file.scripts/version-pr-ci.test.mjspins the new name in its tables. The Step 1 test ("is a dispatch-only placeholder until Step 2") is replaced by one that pins the end state: the old file is gone, no workflow's executable lines name it, and the new file has all four triggers.RELEASING.md, thereleaseskill,docs/quality-gate.mdand theAGENTS.mdtree name the new file.The workflow's
name:(MCP Interface Diff), its job names, theInterface diff (dispatched)status context and the sticky comment marker are unchanged.Server Details
None (repository-wide): CI workflows, gate tooling and docs.
Motivation and Context
#5527. The file diffs every server since #5428 but was still named for Everything. GitHub dispatches a workflow only when its file exists on the default branch, so the rename needed the new name on
mainfirst.Preconditions, checked before starting:
origin/main(c799c855, the v2.5.0 milestone merge, Release v2.5.0: merge v2/main into main #5592) carries.github/workflows/mcp-interface-diff.yml(the placeholder) besideeverything-mcp-diff.yml.MCP Interface Diff (rename placeholder),.github/workflows/mcp-interface-diff.yml, id407692937.Rulesets: no human step needed. No ruleset names an interface diff check. The only required status check in the repository is
Source is v2/mainonmain: milestone merges only;v2/main: PRs onlyrequires none, and neither branch has classic branch protection.Until the next milestone merge,
mainstill holds its owneverything-mcp-diff.yml. Nothing dispatches it after this PR, and the v2.6.0 merge PR deletes it there (its runs come from the PR's merge commit, which has only the new file).How Has This Been Tested?
No client-observable surface, so targeted probes:
node --test scripts/version-pr-ci.test.mjs: 29 pass. Withversion-packages.yml's loop put back oneverything-mcp-diff.yml: 2 fail (the new end-state test and the dispatch-list test). With the old file restored beside the new one: 1 fail (the end-state test). Both reverted: 29 pass.npm run interface-diff -- --base origin/v2/main --listselects all seven servers.npm run local:gateexits 0 on the pushed commit, includinginterface-difffor all seven servers (no interface changes).pull_requestrun of the real diff under the new file name; itsChoose the servers to diffandDiff <server>jobs appear in the checks below.v2/main, so the first version PR after this merges is the live check thatInterface diff (dispatched)still appears. The by-hand equivalent after merge isgh workflow run mcp-interface-diff.yml --ref <branch>.Breaking Changes
None. No server or published package changes.
Types of changes
Checklist
🤖 Generated with Claude Code