Repository navigation
Conversation
A Nexus callback takes only the completion here, since no progress delivery reaches it yet.
2 of 3 tasks
The first-run check compared only with the current chain, so it refused readers of a chain that ended before the Workflow ID was reused. A first run of an earlier chain is taken too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds the stream notifier, a CHASM execution per stream that holds its readers' callbacks.
chasm/lib/streamnotifierkeys a notifier byworkflow/<id>/<first run>/<topic>, so one notifier serves the stream across a run chain.streamnotifier.maxCallbacks. Notify keeps the highest counter and hands it to every callback as progress. Close completes them all.streamnotifier.closedRetention(7 days).streamnotifier.ownerCheckIntervalcloses the stream when the owner chain ended, afterstreamnotifier.ownerCloseGrace.streamnotifier.enabled, off by default.It carries moetemp/temporal#41. Attach still keeps the operation token and start time (DD-70). A Nexus callback takes only the completion here, since its progress delivery stays in Bridge.
Why?
A notifier keyed by the stream survives worker restarts and works for every producer kind (DD-31). An owner that ended closes the stream (DD-73, DD-108).
How did you test it?
Link to a test plan if any -
Unit tests in
chasm/lib/streamnotifier, and the functionalTestStreamNotifier*tests on CHASM and HSM callers.