Repository navigation
Conversation
A Workflow reader in the namespace attaches a stream_wake callback, and the notifier wakes it through History with no Nexus. Rechecks bound the delay after a lost notification, and callbacks of closed runs leave the limits.
No Worker closes a stream when its owner's chain ends, so the owner check bounds an implicit close.
A run counted every reader it ever attached, so the 33rd reader failed the Workflow even with one reader open. A detach, a failed attach and a taken close or resubscribe wake free it.
One scheduled event carries the wakes of all of a run's readers, so near-limit outcomes could stack past the event limit. The reader's final read returns the outcome from the store.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds the Workflow wake target. A Workflow reader attaches with
workflow_target, and the notifier wakes it through History.stream_wakecallback variant sends progress to HistoryRecordStreamWake. Its completion is the close, aresubscribeafter an idle timeout, or nothing after a detach.history.maximumStreamWakeSourcesreaders at once, or to a closed run, fails. A detach, a failed attach, and a taken close orresubscribewake free the place.streamnotifier.recheckInitial(1 min) of quiet the notifier sends arecheckwake, doubling up tostreamnotifier.recheckMax(1 h). A notification resets the gap.streamnotifier.ownerCheckIntervaldrops from 5 min to 30 s. An implicit close then reaches waiting callbacks within about 30 s plus the grace, at one owner describe per interval per notifier with callbacks.Why?
A Signal would add an event and an Action per wake (JD-5). Rechecks close the crash gap without a Redis outbox (JD-10). Dead callbacks must not fill the 2,000 limit (JD-6). With Ford gone, the owner check is the only implicit close (JD-9).
How did you test it?
Link to a test plan if any -
Unit tests in
chasm/lib/callbackandchasm/lib/streamnotifier(TestWorkflowTargets,TestRechecks), and the functionalTestStreamWakeSuiteend to end through the notifier.